Fix logging of asset count in impact calculation#1195
Merged
Conversation
Collaborator
Author
|
@ValentinGebhart @emanuel-schmid It should take 2min to review 😇 |
Collaborator
Author
|
Oh wait I just saw that the tests checked the logging, will update ASAP. |
peanutfun
approved these changes
Dec 17, 2025
Member
peanutfun
left a comment
There was a problem hiding this comment.
Please fix the test and this is good to go! 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the following:
gdf.sizereturn the number of cells, not the number of rows, so the logging message is wrong.This is easily fixed by switching to
len(exp_gdf)PR Author Checklist
develop)PR Reviewer Checklist