Conversation
fix self import
pylint
|
I haven't reviewed the changes, but I looked at this PR because it sounded like you implemented a faster way of reading NetCDF. It might be worthwhile to consider disobeying the naming scheme and uppercasing "FAST" in the method names (i.e., |
climada/hazard/tc_tracks.py
Outdated
| track.time.data, unit="s", origin=reference_time | ||
| ).astype("datetime64[s]") | ||
| # Define variables | ||
| max_wind_kn = track.vmax_trks.data * 1.943844 |
There was a problem hiding this comment.
Prefer defining a constant somewhere and avoid hardcoded values
There was a problem hiding this comment.
Agree, I was trying to avoid the pylint: too many locals 😬
| "SI": 1005, | ||
| "WP": 1005, | ||
| "SP": 1004, | ||
| "AU": 1004, |
There was a problem hiding this comment.
It could be worth mentioning this addition to the changelog for track keeping!
spjuhel
left a comment
spjuhel
left a comment
There was a problem hiding this comment.
👍 Great work @NicolasColombi !
I suggested some very minor changes to make the code even better !
In addition, I am wondering if you could write a brief description in the tutorial on how this can be used (a few lines to exemplify how to run the FAST model, and use these functions on the folder). Not mandatory though.
Thank you Sam! Good point, I will add it! I am wondering whether it should be a short part of the current tropical cyclone tutorial or if I should create a new one, any thoughts on that ? because with #1003 we will be adding an other feature that probably should appear in some tutorial as well and I am hesitant to make it even longer. So I guess, either a short section in the current tutorial or a more descriptive in a new one ? |
Co-authored-by: Samuel Juhel <10011382+spjuhel@users.noreply.github.com>
Co-authored-by: Samuel Juhel <10011382+spjuhel@users.noreply.github.com>
|
I think a brief one is quite enough, it is mostly to show off your work a bit more :) |
Co-authored-by: Samuel Juhel <10011382+spjuhel@users.noreply.github.com>
Fine by me, I will add the documentation all at once in #1003 then. |
|
@spjuhel as discussed, I'll merge. |
3 participants
Changes proposed in this PR:
This PR adds a method to import tropical cyclones tracks from an open source tc model called FAST.
from_FAST(): Import model output in netcdf format, restructure it, compute missing central pressure and radious oftest_from_FAST()PR Author Checklist
develop)PR Reviewer Checklist