Skip to content

[NO TICKET] Add Nursing Home Icon#3962

Open
kamiTT wants to merge 3 commits intoCMSgov:mainfrom
kamiTT:add-nursing-home-icon
Open

[NO TICKET] Add Nursing Home Icon#3962
kamiTT wants to merge 3 commits intoCMSgov:mainfrom
kamiTT:add-nursing-home-icon

Conversation

@kamiTT
Copy link
Copy Markdown
Contributor

@kamiTT kamiTT commented Mar 6, 2026

Summary

Adding a new icon that CXT uses within their application: nursing home

How to test

  1. Build and serve storybook.
  2. Navigate to the medicare icons component
  3. Confirm new icon appears: NursingHomeIcon

Checklist

  • Prefixed the PR title with the Jira ticket number as [CMSDS-####] Title or [NO-TICKET] if this is unticketed work.
  • Selected appropriate Type (only one) label for this PR, if it is a breaking change, label should only be Type: Breaking
  • Selected appropriate Impacts, multiple can be selected.
  • Selected appropriate release milestone

If this is a change to design:

  • If visual regression image references have been changed, design MUST be assigned to review. In this instance, designer approval is a requirement before the PR can be merged.

If this is a change to code:

  • Created or updated unit tests to cover any new or modified code
  • Verified that running both npm run test:unit and npm run test:browser:all were each successful
  • If necessary, updated unit-test snapshots (npm run test:unit:update) and browser-test snapshots (npm run test:browser:all:update)

If this is a change to documentation/content:

  • Checked for spelling and grammatical errors
  • Communicate the assigned milestone/release date with Design so they can communicate appropriately

@kamiTT kamiTT changed the title add nursing home icon [NO TICKET] Add Nursing Home Icon Mar 10, 2026
@jack-ryan-nava-pbc
Copy link
Copy Markdown
Collaborator

not a wolf

@jack-ryan-nava-pbc jack-ryan-nava-pbc added Impacts: Medicare Impacts the Medicare theme directly. Type: Added Indicates a new feature. labels Mar 26, 2026
@jack-ryan-nava-pbc jack-ryan-nava-pbc added this to the 14.0.0 milestone Mar 26, 2026
@jack-ryan-nava-pbc jack-ryan-nava-pbc marked this pull request as ready for review April 2, 2026 19:25
@kamiTT
Copy link
Copy Markdown
Contributor Author

kamiTT commented Apr 2, 2026

@jack-ryan-nava-pbc @tamara-corbalt this is ready for review

Copy link
Copy Markdown
Collaborator

@derek-cmsds derek-cmsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


const defaultProps = {
className: '',
title: 'Nursing Home',
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the t function on the title prop.

Copy link
Copy Markdown
Collaborator

@tamara-corbalt tamara-corbalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part! We’ll probably need snapshot updates here (a little surprised CI passed as-is), and I think we’ll also want to wire the title prop with our translation utility from core.

@kamiTT
Copy link
Copy Markdown
Contributor Author

kamiTT commented Apr 3, 2026

Looks good for the most part! We’ll probably need snapshot updates here (a little surprised CI passed as-is), and I think we’ll also want to wire the title prop with our translation utility from core.

Updated

@kamiTT kamiTT requested a review from tamara-corbalt April 3, 2026 15:44
Copy link
Copy Markdown
Collaborator

@tamara-corbalt tamara-corbalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Impacts: Medicare Impacts the Medicare theme directly. Type: Added Indicates a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants