refactored dashboard.js and dashboard-line-graph.js by reducing lines… #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of similar code
P1B: Starter Task: Refactoring PR
Use this pull request template to briefly answer the questions below in one to two sentences each.
Feel free to delete this text at the top after filling out the template.
1. Issue
Please provide a link to the associated GitHub issue:
Link to the associated GitHub issue:
#267
Full path to the refactored file:
public/src/admin/dashboard.js
What do you think this file does?
(Your answer does not have to be 100% correct; give a reasonable, evidence‑based guess.)
I'm pretty sure dashboard.js fetches data from the serve and creates the graphics and stuff on the admin dashboard
What is the scope of your refactoring within that file?
(Name specific functions/blocks/regions touched.)
renderCustomRangeModal function
Which Qlty‑reported issue did you address?
(Name the rule/metric and include the BEFORE value; e.g., “Cognitive Complexity 18 in render()”.)
public/src/admin/dashboard.js
Found 19 lines of similar code in 2 locations
2. Refactoring
How did the specific issue you chose impact the codebase’s adaptability?
it improved adaptability by simplifying future updates and reducing complexity
What changes did you make to resolve the issue?
created a separate file for the shared function, then called that in both dashboard.js and dashboard-line-graph.js
How do your changes improve adaptability? Did you consider alternatives?
My changes improve adaptability by centralizing logic, so if a developer needs to change this function, they only need to do it in one place rather than two. I did not consider any alternatives.
3. Validation
How did you trigger the refactored code path from the UI?
I logged in using the admin account, went to the admin dashboard, and clicked the "custom time frame" button under the big graph.
Attach a screenshot of the logs and UI demonstrating the trigger.
(Run
./nodebb log; include the relevant UI view. Temporary logs should be removed before final commit.)Attach a screenshot of
qlty smells --no-snippets <full/path/to/file.js>showing fewer reported issues after the changes.