Skip to content

Check for SNe immediately after CEs#765

Merged
katiebreivik merged 5 commits intoCOSMIC-PopSynth:developfrom
TomWagg:sncheck
Feb 24, 2026
Merged

Check for SNe immediately after CEs#765
katiebreivik merged 5 commits intoCOSMIC-PopSynth:developfrom
TomWagg:sncheck

Conversation

@TomWagg
Copy link
Collaborator

@TomWagg TomWagg commented Feb 19, 2026

Previous code didn't check for SNe after a call to hrdiag after a CE. This fixes #764.

Definitely check how I did this, I copied the block of code from the other hrdiag calls and made some slight adjustments to ensure that the evolve_type=8 is still logged each time. I think it works (it fixes my weirdos definitely).

I've also switched the version 3.7.4 so you can release easily.

Oh and I also cleaned up the issue templates.

@TomWagg TomWagg requested a review from katiebreivik February 19, 2026 18:24
@TomWagg TomWagg self-assigned this Feb 19, 2026
@TomWagg TomWagg added the bug label Feb 19, 2026
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 19.31818% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.80%. Comparing base (8772c07) to head (c8e4702).
⚠️ Report is 139 commits behind head on develop.

Files with missing lines Patch % Lines
src/cosmic/src/evolv2.f 20.73% 64 Missing and 1 partial ⚠️
src/cosmic/evolve.py 0.00% 5 Missing ⚠️
src/cosmic/_version.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (19.32%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #765      +/-   ##
===========================================
- Coverage    86.91%   77.80%   -9.10%     
===========================================
  Files           40       50      +10     
  Lines        25542    27510    +1968     
  Branches         0      875     +875     
===========================================
- Hits         22198    21404     -794     
- Misses        3344     5819    +2475     
- Partials         0      287     +287     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@katiebreivik katiebreivik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great -- thanks @TomWagg !

@katiebreivik katiebreivik merged commit 79da03e into COSMIC-PopSynth:develop Feb 24, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Occasionally SNe during CE do not log in bpp

2 participants