Skip to content

Fixes for tides, mean_anomaly, and metallicity error checking#767

Merged
katiebreivik merged 5 commits intoCOSMIC-PopSynth:developfrom
TomWagg:tides
Feb 25, 2026
Merged

Fixes for tides, mean_anomaly, and metallicity error checking#767
katiebreivik merged 5 commits intoCOSMIC-PopSynth:developfrom
TomWagg:tides

Conversation

@TomWagg
Copy link
Collaborator

@TomWagg TomWagg commented Feb 25, 2026

A few small fixes here

  • Prevent tides calculations based on NS/BHs
    • Missing this was previously leading to some BH + NS systems getting disrupted by tides 😅
  • Track mean_anomaly (save to kick_info) array even when a system is disrupted
  • Throw an error if invalid metallicities are provided for evolution

I also made the debugging setup track the kicks as well, previously it just used random kicks.

@katiebreivik I bumped the version to v3.7.5. I don't think you've released 3.7.4 yet(?) but I think this is probably a different version now otherwise we'll hate ourselves in the future when 1000 things changed in a single version haha.

@TomWagg TomWagg requested a review from katiebreivik February 25, 2026 16:24
@TomWagg TomWagg self-assigned this Feb 25, 2026
@TomWagg TomWagg added the bug label Feb 25, 2026
@github-actions github-actions bot added the needs-cmc-review PR touches cosmic core settings and needs CMC review label Feb 25, 2026
@TomWagg
Copy link
Collaborator Author

TomWagg commented Feb 25, 2026

CMC review bot doesn't need to worry here, the changes to evolve.py just check for metallicity. Removing label/comment.

@COSMIC-PopSynth COSMIC-PopSynth deleted a comment from github-actions bot Feb 25, 2026
@TomWagg TomWagg removed the needs-cmc-review PR touches cosmic core settings and needs CMC review label Feb 25, 2026
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.72%. Comparing base (8772c07) to head (64dee44).
⚠️ Report is 140 commits behind head on develop.

Files with missing lines Patch % Lines
src/cosmic/evolve.py 0.00% 4 Missing ⚠️
src/cosmic/src/kick.f 0.00% 3 Missing ⚠️
src/cosmic/_version.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (11.11%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #767      +/-   ##
===========================================
- Coverage    86.91%   77.72%   -9.19%     
===========================================
  Files           40       50      +10     
  Lines        25542    27552    +2010     
  Branches         0      875     +875     
===========================================
- Hits         22198    21414     -784     
- Misses        3344     5851    +2507     
- Partials         0      287     +287     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@katiebreivik katiebreivik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks twagg!

@katiebreivik katiebreivik merged commit adb7262 into COSMIC-PopSynth:develop Feb 25, 2026
5 of 7 checks passed
@TomWagg TomWagg deleted the tides branch February 25, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

COSMIC lets you run high metallicity without warning

2 participants