Skip to content

Fixing comenv SN parameters, adding new wind/remnant/ppisn options#770

Open
xevra wants to merge 27 commits intoCOSMIC-PopSynth:developfrom
xevra:develop
Open

Fixing comenv SN parameters, adding new wind/remnant/ppisn options#770
xevra wants to merge 27 commits intoCOSMIC-PopSynth:developfrom
xevra:develop

Conversation

@xevra
Copy link
Contributor

@xevra xevra commented Mar 11, 2026

This pull request:

  1. Addresses issue preSN masses are still being logged and written from comenv.f #768
  2. Adds the Fryer+2022 remnant mass prescription with fiducial fmix/Mcritnsbh parameters
  3. Adds the "Weak" pulsational pair instability treatment from StarTrack (which still uses remnantflag to determine BH mass after reducing the mass due to a pulsation).
  4. Adds Vink winds multiplied by 0.33
  5. Adds the Bjorklund+2024 Wind mass loss power law
  6. Adds the Krticka+2025 Wind mass loss power law.

Please check my treatment of the disruption event in comenv.f

@xevra
Copy link
Contributor Author

xevra commented Mar 11, 2026

@katiebreivik @TomWagg

@xevra
Copy link
Contributor Author

xevra commented Mar 11, 2026

Something is still wrong with the tests I use locally to test this version of COSMIC.

However, I'm having a hard time determining the issue by myself, and the comenv.f bug needs to be addressed, so I wanted to create the PR, and we can continue to test it before merging it.

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 12.28070% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.43%. Comparing base (8772c07) to head (c6001b1).
⚠️ Report is 141 commits behind head on develop.

Files with missing lines Patch % Lines
src/cosmic/src/assign_remnant.f 0.00% 37 Missing and 1 partial ⚠️
src/cosmic/src/mlwind.f 38.89% 6 Missing and 5 partials ⚠️
src/cosmic/_commit_hash.py 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (12.28%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #770      +/-   ##
===========================================
- Coverage    86.91%   77.43%   -9.48%     
===========================================
  Files           40       51      +11     
  Lines        25542    27670    +2128     
  Branches         0      952     +952     
===========================================
- Hits         22198    21424     -774     
- Misses        3344     5953    +2609     
- Partials         0      293     +293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant