Fixing comenv SN parameters, adding new wind/remnant/ppisn options#770
Open
xevra wants to merge 27 commits intoCOSMIC-PopSynth:developfrom
Open
Fixing comenv SN parameters, adding new wind/remnant/ppisn options#770xevra wants to merge 27 commits intoCOSMIC-PopSynth:developfrom
xevra wants to merge 27 commits intoCOSMIC-PopSynth:developfrom
Conversation
Created maximum wall time argument
Fixed Nan's apparently.
Contributor
Author
Contributor
Author
|
Something is still wrong with the tests I use locally to test this version of COSMIC. However, I'm having a hard time determining the issue by myself, and the comenv.f bug needs to be addressed, so I wanted to create the PR, and we can continue to test it before merging it. |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (12.28%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #770 +/- ##
===========================================
- Coverage 86.91% 77.43% -9.48%
===========================================
Files 40 51 +11
Lines 25542 27670 +2128
Branches 0 952 +952
===========================================
- Hits 22198 21424 -774
- Misses 3344 5953 +2609
- Partials 0 293 +293 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request:
Please check my treatment of the disruption event in comenv.f