Skip to content

Conversation

@CSchoel
Copy link
Owner

@CSchoel CSchoel commented Jun 16, 2025

Closes #48, #45, and #46.

@CSchoel CSchoel self-assigned this Jun 16, 2025
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

❌ Patch coverage is 84.80769% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.51%. Comparing base (e212493) to head (0fbbb8d).
⚠️ Report is 37 commits behind head on dev.

Files with missing lines Patch % Lines
nolds/datasets.py 46.21% 71 Missing ⚠️
nolds/test_measures.py 97.92% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #67      +/-   ##
==========================================
- Coverage   76.10%   74.51%   -1.60%     
==========================================
  Files           4        4              
  Lines        1088     1177      +89     
==========================================
+ Hits          828      877      +49     
- Misses        260      300      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was linked to issues Aug 31, 2025
@CSchoel CSchoel requested a review from Copilot August 31, 2025 17:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the nolds codebase by integrating Ruff for linting and formatting, updating Python version support, and improving code quality throughout.

  • Updates Python support from 3.8+ to 3.10+ and adds Python 3.13 support
  • Applies comprehensive Ruff formatting and linting with updated configuration
  • Adds type hints across the codebase and modernizes import patterns

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
pyproject.toml Updates Python version requirements, Ruff configuration, and dependency formatting
nolds/test_measures.py Adds type hints, modernizes test structure with subTests, and improves documentation
nolds/examples.py Adds type hints, modernizes argument parsing, and improves code formatting
nolds/datasets.py Adds type hints, switches to modern resource loading, and improves documentation
nolds/init.py Reorganizes imports with proper formatting and adds all declaration
doc/source/conf.py Updates string quotes and formatting consistency
CHANGELOG.md Documents all changes made in this release
.vscode/settings.json Enables Ruff formatting and linting in VS Code
.github/workflows/ci.yaml Updates CI to test Python 3.10-3.13 range

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

CSchoel and others added 2 commits August 31, 2025 19:47
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@CSchoel CSchoel merged commit cd85750 into dev Aug 31, 2025
6 checks passed
@CSchoel CSchoel deleted the ruff branch August 31, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant