-
Notifications
You must be signed in to change notification settings - Fork 65
Ruff #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #67 +/- ##
==========================================
- Coverage 76.10% 74.51% -1.60%
==========================================
Files 4 4
Lines 1088 1177 +89
==========================================
+ Hits 828 877 +49
- Misses 260 300 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the nolds codebase by integrating Ruff for linting and formatting, updating Python version support, and improving code quality throughout.
- Updates Python support from 3.8+ to 3.10+ and adds Python 3.13 support
- Applies comprehensive Ruff formatting and linting with updated configuration
- Adds type hints across the codebase and modernizes import patterns
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates Python version requirements, Ruff configuration, and dependency formatting |
| nolds/test_measures.py | Adds type hints, modernizes test structure with subTests, and improves documentation |
| nolds/examples.py | Adds type hints, modernizes argument parsing, and improves code formatting |
| nolds/datasets.py | Adds type hints, switches to modern resource loading, and improves documentation |
| nolds/init.py | Reorganizes imports with proper formatting and adds all declaration |
| doc/source/conf.py | Updates string quotes and formatting consistency |
| CHANGELOG.md | Documents all changes made in this release |
| .vscode/settings.json | Enables Ruff formatting and linting in VS Code |
| .github/workflows/ci.yaml | Updates CI to test Python 3.10-3.13 range |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Closes #48, #45, and #46.