-
Notifications
You must be signed in to change notification settings - Fork 54
Convert "ensure_future" to "create_task" #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||
49c6fe3 to
783eacc
Compare
783eacc to
fbe32d3
Compare
This is recommended by python documentation, event loop only stores weak references to running tasks.
hosaka
approved these changes
Sep 19, 2025
Collaborator
|
@kristjanvalur thank you for contributing! |
Contributor
Author
|
I should add that the previous implementation of asyncClose had a problem: Any uncaught exceptions in the close slot would be silently ignored, since the future's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncio.ensure_futureis an anacronism. Since python version 3.7,create_task()is preferred overensure_future.Moreover, error handling is more natural (and traceback friendly) by using wrapper methods instead of
future completion callbacks.
asyncSlot()exception case.asyncClose()asyncClose()asyncClose()