Ensure external link icon is visible in dark themes#187
Open
ptcodes wants to merge 1 commit intoCachyOS:developfrom
Open
Ensure external link icon is visible in dark themes#187ptcodes wants to merge 1 commit intoCachyOS:developfrom
ptcodes wants to merge 1 commit intoCachyOS:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The external link icon is currently a dark PNG image, which becomes almost invisible when using a dark theme (e.g. Breeze Dark):
Solution
Replace the PNG icon with a symbolic SVG icon. Symbolic icons automatically adapt their color based on the active theme, ensuring proper visibility in both light and dark themes.
Result
The external link icon now remains visible and consistent across different themes: