config: Sync CPU related options with 6.15 PKGBUILD#51
Merged
vnepogodin merged 2 commits intodevelopfrom May 26, 2025
Merged
Conversation
The auto_cpu_optimization script has been removed in 6.15. All native builds will now use _processor_opt=native to use -march=native. Remove the check here to sync with the PKGBUILD. Signed-off-by: Eric Naim <dnaim@cachyos.org>
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes CPU-related options by removing the deprecated automatic optimization flag and updating the CPU optimization modes across the configuration, UI, and FFI layers.
- Removed
auto_optim_checkreferences in header, source, UI, JSON schema, and Rust FFI - Updated
cpu_opt_modeconstants and combobox labels to new CPU optimization options - Cleaned up obsolete entries in
compile_options.jsonandlib.rs
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/config-options.hpp | Removed deprecated auto_optim_check field |
| src/config-options.cpp | Stripped out parsing and writing of auto_optim_check |
| src/conf-window.cpp | Updated lookup macro for CPU options; removed autooptim UI code |
| src/conf-options-page.ui | Deleted the autooptim_widget UI block |
| src/compile_options.json | Removed "auto_optim" mapping |
| config-option-lib/src/lib.rs | Removed auto_optim_check from Rust FFI struct |
Comments suppressed due to low confidence (2)
src/conf-window.cpp:108
- [nitpick] The key
manualis now displayed asDisabledin the combobox. Consider aligning the lookup key or the label for consistency or add a comment clarifying this mapping to avoid confusion.
GENERATE_CONST_LOOKUP_OPTION_VALUES(cpu_opt_mode, "manual", "generic", "generic_v2", "generic_v3", "generic_v4", "native", "zen4")
src/compile_options.json:18
- Ensure any documentation or schema definitions referencing the removed
auto_optimoption are updated to prevent stale references and inform users of its deprecation.
"auto_optim": "_use_auto_optimization",
vnepogodin
requested changes
May 26, 2025
6.15 removed a bunch of different CPU configurations. The only valid configs are now v1-4 x86_64, zen4, and native. Co-authored-by: Vladislav Nepogodin <nepogodin.vlad@gmail.com> Signed-off-by: Eric Naim <dnaim@cachyos.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50