-
Notifications
You must be signed in to change notification settings - Fork 18
URL sanitizer for help pages #3844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL sanitizer for help pages #3844
Conversation
…firewall-orchestrator into fix-security-url-sanitizing
|
@tpurschke Maybe add some test cases from XSS_Filter_Evasion_Cheat_Sheet ? good thinking but because of time-criticality I would like to postpone this - could you please create an issue for this which we can tackle later? |
|
I would be happy to review this, but I dont have any clue how to test it. In respect of our short cut time window I would suggest, that the testing should be done, by somebody who is familiar with these kind of attacks, so that we dont have to spend the time I need to research this topic. Best would be if somebody who is familiar with this topic could do the testing and I could just witness the act, so that I know for the next time. |
shall we have a quick call regarding this issue so that I can show you the ropes? |
Let's do that tommorow. |
…firewall-orchestrator into fix-security-url-sanitizing
…schke/firewall-orchestrator into fix-security-url-sanitizing
|
@SolidProgramming @NilsPur adding some more eyes - your review is appreciated for this security fix |
|
|
The thing handeled with "MyRegex", "MyRegex1", "MyRegex2" is bad named. I would haven taken a look at the cleaning because i would have done this with more regex but i guess it's not needed anymore. |



closing #3810
not using this sanitizer to protect _blazor calls as this is unnecessary and may break things