Sync develop → importer-rework #3847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change suppresses the protocol name output in case the Any/All service is used
Deemed as false positive, Initialize() already sets them both and has no point of failure that could clear them
The subscription could potentially be null after creation if initialization fails to subscribe; resubscribing until success could take an infinite time; therefore, an exception was chosen. subscriptionStream can't be null here, false positive
Made ApiConnection nullable, not important for already existing code, which was working without a forced value for ApiConnection, but might be relevant for future development
Added a read-only field, currently unused, but data is at least preserved. Arguably, whether a property or a field is more sensible for the sake of data privacy field was chosen
Missed a trickling warning while changing Config.cs
Recommendation is to use top level rout registration in projects for .NET 6+, but if a custom PipelineStructure or other explicit ordering is necessary. otherwise replace lines 170-173 with app.MapControllers()
if during dispose a value is nulled all code should reflect that possibility
Blazor standard is to avoid custom get/setters, i found no reason to break this standard here
Made small staging mistake
(bool) null should resolve to false, but let's not try it out, this has the same behavior and the added bonus of a happy warning
Same problems as previous commit, same solution
v8.9.1 Connection Based Recertification Module
Merge pull request #3808 from CactuseSecurity/develop (only version number)
- should be no more whitespace changes in replace_metadata
fix(UI): Interface overview publication state icon broken
fix(UI): Modelling Connections button width
fix #3812 in develop
Issue/2896 owner_lifecycle_state
Develop fix IsPublished
github-actions
bot
added
the
automation
ISSUE develop - update permissions for owner - owner lifecycle states
v8.9.2 - Develop to main
main to develop - just version number commit
|
tpurschke
closed this pull request by merging all changes
into
importer-rework
in
5842127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-sync from
developvia sync branch.