Open
Conversation
I should come up with a concrete name for this dataset... I do it next time okay?
Added various V2 and V3 lighting components (lacks inheritance) Updated EnvironmentData class to latest schema Added "layer" property to EnvironmentObject
Just a few changes some of which include: Modulate EnvironmentInfo to its own assembly (affected parent folder scripts? will look into in the future) Switched EnvData and EnvInfo classes. Initialized EnvironmentComponent on some lightable components.
The other ones SUCKED!
Didn't get *all* of them as some may still be helpful ex: LightEffects, CoreLighting, etc..
This fixes some environments being prevented to load (like BigMirror) because "mirror" was an exclusion entry. Old comparison: BigMirrorEnvironment.[0]Environment.[10]BasicGameHUD New: Environment.[10]BasicGameHUD
Updated EnvInfo files to latest schema Deleted EnvironmentBuildSOs
…kov-redo-environments
…kov-redo-environments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the long awaited environment rework is approaching
this does not mean GLS lighting can be done yet, it will be the next step
if you wish to see environment in proper visual, do contribute on making an asset and shader better
final check to find any glaring issue that should be addressed before pushing to dev
known issue(s):