Improved Portal Search #682
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arraylist_sl merge lithium patch
…ing poisections for some reason
# Conflicts: # common/src/main/java/net/caffeinemc/mods/lithium/common/util/Distances.java
Member
|
Merged manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewriting parts of NearbyPointOfInterestStream to remove the chunk sorting at the start and prioritize closer subchunks first - current one prioritizes closer chunks.
Some other improvements aim at returning POIs early were also included.
Tradeoff is that POI subchunks need to get sorted so the worst case is worse - if a lot of subchunks get queued and sorted - although this should not be a common occurrence.
Performance:
See discord
Not entirely satisfied with the worst relative case results but it likely is better in more scenarios than the current implementation
Note:
This is still a draft as of me opening this - this is why the new NearbyPointOfInterestStream in a 2nd file.
I have tested it for non-vanilla linking but it is possible that something was overlooked.