Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the default password rehash configuration to use the newer “authenticator → identifier” mapping approach and adjusts/extends unit tests around login password rehash behavior.
Changes:
- Update
Auth.PasswordRehashconfiguration to useauthenticatorsmapping instead ofidentifiers. - Refactor
testLoginRehash()to mock authenticator/identifier structure for the rehash path. - Add a new test that attempts to cover an authenticator identifier name like
Authentication.Password.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/TestCase/Controller/Traits/LoginTraitTest.php | Updates and extends login password rehash tests using authenticator-based configuration/mocking. |
| config/users.php | Switches default PasswordRehash config to Auth.PasswordRehash.authenticators mapping (Form → Authentication.Password). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.