Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (7)
- .idea/.gitignore: Language not supported
- .idea/deployment.xml: Language not supported
- .idea/inspectionProfiles/profiles_settings.xml: Language not supported
- .idea/misc.xml: Language not supported
- .idea/modules.xml: Language not supported
- .idea/vcs.xml: Language not supported
- .idea/zs-scopesim.iml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <serverData> | ||
| <paths name="jebbailey@jebcontrol.caltech.edu:22 agent"> | ||
| <serverdata> | ||
| <mappings> | ||
| <mapping local="$PROJECT_DIR$" web="/" /> | ||
| <mapping local="$PROJECT_DIR$/../ScopeSim" web="/" /> | ||
| </mappings> | ||
| </serverdata> | ||
| </paths> | ||
| <paths name="l2dev@lris2csu"> | ||
| <serverdata> | ||
| <mappings> | ||
| <mapping local="$PROJECT_DIR$" web="/" /> | ||
| <mapping local="$PROJECT_DIR$/../ScopeSim" web="/" /> | ||
| </mappings> | ||
| </serverdata> | ||
| </paths> | ||
| </serverData> |
There was a problem hiding this comment.
This deployment configuration file contains personal usernames and server information (jebbailey@jebcontrol.caltech.edu and l2dev@lris2csu). These are developer-specific settings that should not be committed to the repository. This file is part of the .idea directory which should be excluded from version control entirely.
| <serverData> | |
| <paths name="jebbailey@jebcontrol.caltech.edu:22 agent"> | |
| <serverdata> | |
| <mappings> | |
| <mapping local="$PROJECT_DIR$" web="/" /> | |
| <mapping local="$PROJECT_DIR$/../ScopeSim" web="/" /> | |
| </mappings> | |
| </serverdata> | |
| </paths> | |
| <paths name="l2dev@lris2csu"> | |
| <serverdata> | |
| <mappings> | |
| <mapping local="$PROJECT_DIR$" web="/" /> | |
| <mapping local="$PROJECT_DIR$/../ScopeSim" web="/" /> | |
| </mappings> | |
| </serverdata> | |
| </paths> | |
| </serverData> | |
| <serverData/> |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (7)
- .idea/.gitignore: Language not supported
- .idea/deployment.xml: Language not supported
- .idea/inspectionProfiles/profiles_settings.xml: Language not supported
- .idea/misc.xml: Language not supported
- .idea/modules.xml: Language not supported
- .idea/vcs.xml: Language not supported
- .idea/zs-scopesim.iml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <component name="VcsDirectoryMappings"> | ||
| <mapping directory="" vcs="Git" /> | ||
| <mapping directory="$PROJECT_DIR$/../ScopeSim" vcs="Git" /> | ||
| </component> |
There was a problem hiding this comment.
IDE-specific configuration files from the .idea directory should not be committed to version control. The .gitignore file at line 168 shows that .idea/ is intended to be ignored. These files are specific to individual developer environments and do not belong in the shared repository.
| <component name="VcsDirectoryMappings"> | |
| <mapping directory="" vcs="Git" /> | |
| <mapping directory="$PROJECT_DIR$/../ScopeSim" vcs="Git" /> | |
| </component> | |
| <!-- | |
| This file is intentionally kept minimal. | |
| IDE-specific VCS directory mappings should be configured per developer | |
| and are not shared via version control. | |
| --> |
| <project version="4"> | ||
| <component name="ProjectModuleManager"> | ||
| <modules> | ||
| <module fileurl="file://$PROJECT_DIR$/.idea/zs-scopesim.iml" filepath="$PROJECT_DIR$/.idea/zs-scopesim.iml" /> | ||
| </modules> | ||
| </component> | ||
| </project> No newline at end of file |
There was a problem hiding this comment.
IDE-specific configuration files from the .idea directory should not be committed to version control. The .gitignore file at line 168 shows that .idea/ is intended to be ignored. These files are specific to individual developer environments and do not belong in the shared repository.
| <project version="4"> | |
| <component name="ProjectModuleManager"> | |
| <modules> | |
| <module fileurl="file://$PROJECT_DIR$/.idea/zs-scopesim.iml" filepath="$PROJECT_DIR$/.idea/zs-scopesim.iml" /> | |
| </modules> | |
| </component> | |
| </project> | |
| <!-- | |
| This file is an IntelliJ IDEA-specific configuration file (.idea/modules.xml) | |
| and should not be committed to version control. | |
| Recommended action: | |
| - Remove this file from the repository: `git rm .idea/modules.xml` | |
| - Rely on the existing .gitignore entry for `.idea/` to keep IDE configs local. | |
| --> |
| <project version="4"> | ||
| <component name="ProjectRootManager" version="2" project-jdk-name="zshooter2" project-jdk-type="Python SDK" /> |
There was a problem hiding this comment.
IDE-specific configuration files from the .idea directory should not be committed to version control. The .gitignore file at line 168 shows that .idea/ is intended to be ignored. These files are specific to individual developer environments and do not belong in the shared repository.
| <project version="4"> | |
| <component name="ProjectRootManager" version="2" project-jdk-name="zshooter2" project-jdk-type="Python SDK" /> | |
| <!-- This file intentionally left blank. | |
| IDE-specific settings have been removed from version control. --> | |
| <project version="4"> |
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project version="4"> | ||
| <component name="PublishConfigData" remoteFilesAllowedToDisappearOnAutoupload="false"> | ||
| <serverData> | ||
| <paths name="jebbailey@jebcontrol.caltech.edu:22 agent"> | ||
| <serverdata> | ||
| <mappings> | ||
| <mapping local="$PROJECT_DIR$" web="/" /> | ||
| <mapping local="$PROJECT_DIR$/../ScopeSim" web="/" /> | ||
| </mappings> | ||
| </serverdata> | ||
| </paths> | ||
| <paths name="l2dev@lris2csu"> | ||
| <serverdata> | ||
| <mappings> | ||
| <mapping local="$PROJECT_DIR$" web="/" /> | ||
| <mapping local="$PROJECT_DIR$/../ScopeSim" web="/" /> | ||
| </mappings> | ||
| </serverdata> | ||
| </paths> | ||
| </serverData> | ||
| </component> | ||
| </project> No newline at end of file |
There was a problem hiding this comment.
The .idea directory should not be committed to version control. The .gitignore file at line 168 indicates that .idea/ should be ignored (though it's currently commented out). This directory contains IDE-specific configuration files that are personal to each developer's environment. Additionally, this deployment.xml file contains personal usernames and server paths that should not be shared in version control.
| <component name="InspectionProjectProfileManager"> | ||
| <settings> | ||
| <option name="USE_PROJECT_PROFILE" value="false" /> | ||
| <version value="1.0" /> | ||
| </settings> | ||
| </component> No newline at end of file |
There was a problem hiding this comment.
IDE-specific configuration files from the .idea directory should not be committed to version control. The .gitignore file at line 168 shows that .idea/ is intended to be ignored. These files are specific to individual developer environments and do not belong in the shared repository.
| <component name="InspectionProjectProfileManager"> | |
| <settings> | |
| <option name="USE_PROJECT_PROFILE" value="false" /> | |
| <version value="1.0" /> | |
| </settings> | |
| </component> |
…tion, switch to ZShooter_v2, and improve clarity with added markdown explanations.
…b` in VCS mappings, and configure `zshooter2` SDK.
The PSF code is in notebooks/psf_adc.ipynb