Security: Added URI validation to prevent file system manipulation #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes CanHub#613) - Added validateOutputUri() function to validate custom output URIs - Only allow content:// URIs, reject file:// URIs to prevent file system attacks - Validate file extensions match compress format (JPEG→.jpg/.jpeg, PNG→.png, WEBP→.webp) - Added 11 comprehensive unit tests for URI validation - Update CHANGELOG.md with security fix documentation This fix prevents malicious apps from: - Using file:// URIs to overwrite sensitive files (e.g., SharedPreferences) - Writing arbitrary file types by extension mismatch - Exploiting the exported CropImageActivity as described in issue CanHub#613
Canato
approved these changes
Nov 19, 2025
Member
Canato
left a comment
Canato
left a comment
There was a problem hiding this comment.
Approving, if anything someone who need another scheme or type we can adjust with more knowledge, but this changes are sensible and welcome
Will give another day in case someone else wanna raise something, otherwise we merge tomorrow
Author
|
Thank you, @Canato ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #613
This fix prevents malicious apps from: