Open
Conversation
AndreMiras
force-pushed
the
feature/paths-filter
branch
from
181186d to
88b6095
Compare
The technote-space/get-diff-action repo is no longer maintained and archived. Last commit was 2 years ago. On the other hand dorny/paths-filter is actively maintained, last commit was 6 months ago and has far more stars 2100 vs 190 for get-diff-action. Last but not least paths-filter would better handle push force scenario. Also bump actions versions to keep the CI up to date.
AndreMiras
force-pushed
the
feature/paths-filter
branch
from
88b6095 to
be63d9b
Compare
AndreMiras
added a commit
to AndreMiras/Canto
that referenced
this pull request
Aug 27, 2024
Make static builds and upload them as artifacts. This makes it possible to download the binary produced for each PR. In a follow up PR we could also automate binary upload upon release as well as enabling cross compilation for different arch and OS. Note that we use musl-gcc as it allows to statically link a libc implementation while CGO_ENABLED=0 only was leading to the error below: ``` ethermint@v0.22.0-sdk50-1/app/ante/eip712.go:293:36: undefined: secp256k1.RecoverPubkey ethermint@v0.22.0-sdk50-1/app/ante/eip712.go:319:17: undefined: secp256k1.VerifySignature ``` The statically linked binary is 100M as of today. Also drop get-diff-action as it's unmaintained and was misbehaving on the rebasing and squashing workflow, refs Canto-Network#139
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The technote-space/get-diff-action repo is no longer maintained and archived. Last commit was 2 years ago.
On the other hand dorny/paths-filter is actively maintained, last commit was 6 months ago and has far more stars 2100 vs 190 for get-diff-action. Last but not least paths-filter would better handle push force scenario.
Also bump actions versions to keep the CI up to date.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...