Merged
Conversation
danoswaltCL
requested review from
VivekFitkariwala,
bcb37,
ppratikcr7 and
zackcl
danoswaltCL
force-pushed
the
fix/refetch-metrics-after-experiment-upsert
branch
from
0ebb339 to
5245e4f
Compare
Collaborator
Author
|
@zackcl can you review this one? |
VivekFitkariwala
approved these changes
Feb 24, 2025
zackcl
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #2207, metrics need refetched on experiment upsert so the UI will know about the new reward metric. This will work for create, edit, and import.