Fixed icons when opening bags in non-contiguous order#37
Open
jmaxor wants to merge 1 commit intoCartas:masterfrom
Open
Fixed icons when opening bags in non-contiguous order#37jmaxor wants to merge 1 commit intoCartas:masterfrom
jmaxor wants to merge 1 commit intoCartas:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly, thanks for the addon!
This is a fix for a bug where the coin icon wouldn't always show correctly if you have empty bag slots to the right of bags that were open. Based on the comments it looks like this specific oddity with
ContainerFrameindices was known about, but theC_Container.GetContainerNumSlotscall got left out of the fix. This change simply moves getting the bagNumber up so that it can be used for this call.