Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 6, 2025

Bumps the prod group with 1 update: @mapbox/tile-cover.

Updates @mapbox/tile-cover from 3.0.1 to 3.0.2

Commits
Maintainer changes

This version was pushed to npm by mourner, a new releaser for @​mapbox/tile-cover since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 6, 2025
@dependabot dependabot bot requested a review from a team February 6, 2025 16:03
Copy link
Contributor

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing test, looks like a real failure. Will need investigation.

@felixpalmer
Copy link
Collaborator

See #13 & mapbox/tile-cover#87

@felixpalmer
Copy link
Collaborator

I spent some time trying to integrate this bump a while back without success. Unless the above issues have been resolved, bumping the package will break antimeridian handling

@donmccurdy
Copy link
Contributor

donmccurdy commented Feb 10, 2025

Thanks @felixpalmer! Let's block dependabot from updating this dependency then, and make a note about the reason:

I suppose the ideal thing might be if we could upstream a fix to @mapbox/tile-cover, eventually?

Bumps the prod group with 1 update: [@mapbox/tile-cover](https://github.com/mapbox/tile-cover).


Updates `@mapbox/tile-cover` from 3.0.1 to 3.0.2
- [Commits](mapbox/tile-cover@v3.0.1...v3.0.2)

---
updated-dependencies:
- dependency-name: "@mapbox/tile-cover"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: prod
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/prod-9f5e82c38d branch from 177aec1 to 1385b0e Compare February 11, 2025 12:37
@felixpalmer
Copy link
Collaborator

That would be ideal, but I seem to recall that the breaking change was in fact a feature, so the author of the package didn't want to revert

@donmccurdy
Copy link
Contributor

My impression is that it's a bugfix in mapbox/tilebelt (no PR would be accepted) but a regression in mapbox/tile-cover (PR might be accepted for mapbox/tile-cover#87 ?). But the issue has been open for quite a while there, so I suppose we'd want to ping them and ask before working on it from that side.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 11, 2025

Looks like @mapbox/tile-cover is no longer being updated by Dependabot, so this is no longer needed.

@dependabot dependabot bot closed this Feb 11, 2025
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/prod-9f5e82c38d branch February 11, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants