-
Notifications
You must be signed in to change notification settings - Fork 1
Bump @mapbox/tile-cover from 3.0.1 to 3.0.2 in the prod group #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
donmccurdy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing test, looks like a real failure. Will need investigation.
|
See #13 & mapbox/tile-cover#87 |
|
I spent some time trying to integrate this bump a while back without success. Unless the above issues have been resolved, bumping the package will break antimeridian handling |
|
Thanks @felixpalmer! Let's block dependabot from updating this dependency then, and make a note about the reason: I suppose the ideal thing might be if we could upstream a fix to |
Bumps the prod group with 1 update: [@mapbox/tile-cover](https://github.com/mapbox/tile-cover). Updates `@mapbox/tile-cover` from 3.0.1 to 3.0.2 - [Commits](mapbox/tile-cover@v3.0.1...v3.0.2) --- updated-dependencies: - dependency-name: "@mapbox/tile-cover" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: prod ... Signed-off-by: dependabot[bot] <support@github.com>
177aec1 to
1385b0e
Compare
|
That would be ideal, but I seem to recall that the breaking change was in fact a feature, so the author of the package didn't want to revert |
|
My impression is that it's a bugfix in mapbox/tilebelt (no PR would be accepted) but a regression in mapbox/tile-cover (PR might be accepted for mapbox/tile-cover#87 ?). But the issue has been open for quite a while there, so I suppose we'd want to ping them and ask before working on it from that side. |
|
Looks like @mapbox/tile-cover is no longer being updated by Dependabot, so this is no longer needed. |
Bumps the prod group with 1 update: @mapbox/tile-cover.
Updates
@mapbox/tile-coverfrom 3.0.1 to 3.0.2Commits
0d3f34c3.0.2f5f784emodernize eslint rules and fix test/bench issues327d777upgrade dependencies42dc57cUpdate to org scopee486a99Merge pull request #74 from mapbox/add-mapbox-namespace0df9910Move package to@mapboxnamespace.de368f4update travis node versions36f3db3fix travis badge33fdaaaMerge pull request #72 from mapbox/missing-requiree37933fAdd missing require for the example scriptMaintainer changes
This version was pushed to npm by mourner, a new releaser for
@mapbox/tile-coversince your current version.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions