Skip to content

Conversation

@Johnetordoff
Copy link

@Johnetordoff Johnetordoff commented Oct 30, 2025

  • Ticket: []
  • Feature flag: n/a

Purpose

Match the existing notification values to the new notification refactor

Summary of Changes

export enum SubscriptionFrequency {
  Never = 'none',
  Daily = 'daily',
  Instant = 'instant',
}

to

export enum SubscriptionFrequency {
  Never = 'none',
  Daily = 'daily',
  Instant = 'instantLY',
}

Screenshot(s)

No visible changes

Side Effects

QA Notes

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 53.833%. remained the same
when pulling 111bfc1 on fix-update-FE-for-NR
into 95a1cbc on develop.

@Johnetordoff
Copy link
Author

Dear reviewers, this might be the only thing that needs changing in the FE if that's the case we may want to make this backward compatible to simplify the NR release, add thoughts about that, because obviously this breaks current OSF versions.

@brianjgeiger
Copy link
Contributor

Probably we should make a notifications refactor branch for angular osf.

@brianjgeiger brianjgeiger changed the base branch from develop to feature/notifications-refactor October 30, 2025 13:58
@brianjgeiger
Copy link
Contributor

Done

@Johnetordoff
Copy link
Author

@brianjgeiger this PR in conjunction with CenterForOpenScience/osf.io#11405 seem to make all issues go away. But I don't think staging1 is set to this the new branch. I think that still needs to be done to get back to QA.

@brianjgeiger
Copy link
Contributor

Staging is on the new branch, but this isn't merged yet.

@Johnetordoff Johnetordoff merged commit d039a60 into feature/notifications-refactor Oct 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants