Skip to content

[ENG-8524] Update permissions for write preprint contributors #11272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feature/pbs-25-21
Choose a base branch
from
Open

[ENG-8524] Update permissions for write preprint contributors #11272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion api/actions/permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,26 @@ def has_object_permission(self, request, view, obj):
else:
# Moderators and node admins can trigger state changes.
is_node_admin = target is not None and target.has_permission(auth.user, osf_permissions.ADMIN)
if not (is_node_admin or auth.user.has_perm('view_submissions', provider)):
is_write_contributor = target is not None and target.has_permission(auth.user, osf_permissions.WRITE)

provisional_write_allowed = False
if is_write_contributor:
try:
serializer = view.get_serializer(data=request.data)
serializer.is_valid(raise_exception=True)
trigger = serializer.validated_data.get('trigger')
Copy link
Contributor

@antkryt antkryt Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you already have

serializer = view.get_serializer(data=request.data)
serializer.is_valid(raise_exception=True)
trigger = serializer.validated_data.get('trigger')

below, no need to call it again here

provisional_write_allowed = trigger == ReviewTriggers.SUBMIT.value
except Exception:
provisional_write_allowed = False

if not (is_node_admin or auth.user.has_perm('view_submissions', provider) or provisional_write_allowed):
return False

# User can trigger state changes on this reviewable, but can they use this trigger in particular?
serializer = view.get_serializer(data=request.data)
serializer.is_valid(raise_exception=True)
trigger = serializer.validated_data.get('trigger')
Copy link
Contributor

@antkryt antkryt Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRY

permission = TRIGGER_PERMISSIONS[trigger]
if permission is None and is_write_contributor and trigger == ReviewTriggers.SUBMIT.value:
return True
return permission is None or request.user.has_perm(permission, target.provider)
Loading