-
Notifications
You must be signed in to change notification settings - Fork 351
Spelling #11379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #11379
Conversation
| @@ -28,7 +28,7 @@ | |||
| .wiki-sidenav h4 { | |||
| margin-top:20px; | |||
| margin-bottom: 0; | |||
| font-weigth: normal; | |||
| font-weight: normal; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notable
| SESSION_COOKIE_HTTPONLY=true | ||
| SESSION_COOKIE_SAMESITE=Lax | ||
| OSF_SENSITIVE_DATA_SECRET="TrainglesAre5Squares" | ||
| OSF_SENSITIVE_DATA_SECRET="TrianglesAre5Squares" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming no one cares.
| ## Ticket | ||
|
|
||
| <!-- Link to JIRA ticket, if applicable e.g. https://openscience.atlassian.net/browse/OSF-1234 --> | ||
| <!-- Link to Jira ticket, if applicable e.g. https://openscience.atlassian.net/browse/OSF-1234 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brand
|
|
||
| 1. Install the Docker Client | ||
| - OSX: https://www.docker.com/products/docker#/mac | ||
| - macOS: https://www.docker.com/products/docker#/mac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-...ers/managment_commands/test_sync_dois.py
+...ers/management_commands/test_sync_dois.pyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-...ons/views/test_regisatration_callbacks.py
+...ons/views/test_registration_callbacks.pyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-...iews/test_registrations_childrens_list.py
+...iews/test_registrations_children_list.pyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-tests/test_project_contibutor_views.py
+tests/test_project_contributor_views.pyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-...merican_Economic_Review_Resgistration.txt
+...merican_Economic_Review_Registration.txt|
I'll be reviewing this PR either today or tomorrow, depending on availability. For both of these PRs, I will check with others and update the target branch accordingly if that's ok with you. Sorry for the delay in getting back to you, and thank you so much for your contributions! |
futa-ikeda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This took a little longer to get through than expected! Thank you for all the work here! I think the biggest change that gave me pause was one of the URL patterns that we use has a typo in it (external_login_comfirm_email using "coMfirm" with an "M"). To make sure we don't mess up the routing for any existing links with that typo, I would err on the side of caution and avoid replacing the route, and just add a new route with the correct spelling that does the same thing. I'll leave a comment with the suggested change. There's another wording change regarding an email that goes out to deleted users that I want to run past our product team and make sure they are ok with that update.
| operation['source_field_name'] = '_path' | ||
| # NOTE: This is potentially fragile, if we ever add filtering on provider | ||
| # we're going to have to get a bit tricky. get_default_queryset should ramain filtering on BaseFileNode, for now | ||
| # we're going to have to get a bit tricky. get_default_queryset should retain filtering on BaseFileNode, for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be "remain" in this case?
api/users/urls.py
Outdated
| urlpatterns = [ | ||
| re_path(r'^reset_password/$', views.ResetPassword.as_view(), name=views.ResetPassword.view_name), | ||
| re_path(r'^external_login_comfirm_email/$', views.ExternalLoginConfirmEmailView.as_view(), name=views.ExternalLoginConfirmEmailView.view_name), | ||
| re_path(r'^external_login_confirm_email/$', views.ExternalLoginConfirmEmailView.as_view(), name=views.ExternalLoginConfirmEmailView.view_name), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, yea, this may cause some existing links to break. My hunch is to leave the old misspelled path, and add the correct spelling path instead.
| filter_str = 'fitler[name]' | ||
| filter_str = 'filter[name]' | ||
| match = self.filter_regex.match(filter_str) | ||
| assert not match | ||
|
|
||
| def test_single_field_non_alphanumeric_character(self): | ||
| filter_str = 'fitler[<name>]' | ||
| filter_str = 'filter[<name>]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this is a notable change, but now this should actually be testing what we want it to test, so should be an improvement.
|
|
||
| def test_bulk_creates_children_and_sanitizes_html_logged_in_owner( | ||
| self, app, user, project, url): | ||
| title = '<em>Reasoning</em> <strong>Aboot Projects</strong>' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one gave me a chuckle 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a (relatively new) Canadian, things like this definitely give me a chuckle.
| user=contributor, | ||
| submitter=user, | ||
| is_initator=self.creator == contributor, | ||
| is_initiator=self.creator == contributor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving myself a reminder here: if /website/templates/emails/collection_submission_submitted.html.mako is updated with this change, I think we are ok
|
|
||
| RESOURCE_ADDED = 'resource_identifier_added' | ||
| RESOURCE_UPDATED = 'resource_identifier_udpated' | ||
| RESOURCE_UPDATED = 'resource_identifier_updated' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment for self: potentially notable change here as this is likely used in the frontend. Check front-end repo to make sure this isn't being used with the typo included
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we should be ok with this corrected spelling https://github.com/CenterForOpenScience/angular-osf/blob/main/src/assets/i18n/en.json#L3052
| '_id': 'cornell', | ||
| 'name': 'Cornell University', | ||
| 'description': 'Supported by the Cornell Research Data Management Service Group and the Cornell University Library. The OSF service may not be used to store or transfer personally identifiable, confidential/restricted, HIPPA-regulated or any other controlled unclassified information. Learn more at <a href="https://data.research.cornell.edu">https://data.research.cornell.edu</a> | <a href="mailto:rdmsg-help@cornell.edu">rdmsg-help@cornell.edu</a>.', | ||
| 'description': 'Supported by the Cornell Research Data Management Service Group and the Cornell University Library. The OSF service may not be used to store or transfer personally identifiable, confidential/restricted, HIPAA-regulated or any other controlled unclassified information. Learn more at <a href="https://data.research.cornell.edu">https://data.research.cornell.edu</a> | <a href="mailto:rdmsg-help@cornell.edu">rdmsg-help@cornell.edu</a>.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine to update these, as these descriptions are separate from the ones we should be using in production. These are scripts used to populate institutions during local development.
| @@ -8,7 +8,7 @@ | |||
| Hello ${user.fullname},<br> | |||
| <br> | |||
| <p> | |||
| % if is_initator: | |||
| % if is_initiator: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to myself (and any other reviewer), this is updated in `osf/models/collection_submission.py as well
| Your OSF account has been deactivated. You will not show up in search, nor will a profile be visible for you. | ||
| Your OSF account has been deactivated. You will not show up in search, nor will your profile be visible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will bring this up with our Product team to make sure this language change is ok with them
|
@futa-ikeda I presume someone will manage the actual final approval and merge process? I also because, I occasionally run into projects that forget that external contributors exist & can't merge their own pull requests. |
|
Yes, I'll be pinging someone with higher access levels than myself to run CI workflows and to merge tomorrow! It's after working ours here now, so I'll be looking to do that tomorrow. Appreciate your patience as we have had a lot of high priority items coming in these past few weeks. |
|
Seems there's a couple of errors
flake8 linting error here. Seems like the suggestion I made didn't pass linting. My apologies.
Looks like I misunderstood the updates made in this file. It seems the test here purposefully misspells "filter" as "fitler" to ensure that these don't return any matches. Could you revert the changes made to this file? |
|
I've also changed the target branch to our latest bugs and improvement branch |
|
It looks like there are now some merge conflicts in this PR as well. Would you mind resolving them please? Edit: took a look at the places where there are merge conflicts and it looks like the changes in Only the change |
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
|
Sorry, I missed that you changed the base branch and I'm not tracking it... |
|
No worries. I appreciate you updating your PR so quickly every time! It looks like the failure in the CI workflow is a flake8 issue that was introduced in a prior PR. I will go ahead and merge this PR and address that flake8 issue in a PR of my own. Thank you again for all of your hard work! |
5bc34b0
into
CenterForOpenScience:feature/pbs-25-21
* spelling: dashed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: data for Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: database Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: datacite Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: decode Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: deleted Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: delimiters Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: descendents Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: description Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: desynchronized Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: development Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: dictionaries Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: disconnect Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: distinguishing Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: draggable Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: each Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: educational Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: effects tested Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: efficient Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: elsewhere Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: embargoed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: endpoint Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: engagement Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: enqueues Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: entire Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: entries Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: error Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: exactly Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: exceeds Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: existence Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: existing Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: expected Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: explicit Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: explicitly Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: expression Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: extension Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: extract Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: fall back Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: fetch Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: filter Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: finalize Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: flag Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: flattened Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: flexibility Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: for Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: from Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: function Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: further Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: github Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: gitlab Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: given by the referrer Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: gives users Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: greatgreatgrandchild Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: guarantee Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: guid Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: hierarchy Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: hipaa Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: how you Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: icar Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: id Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: identifying Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: images Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: implicit Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: in Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: include Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: includes Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: indeed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: information Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: initially Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: initiation Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: initiator Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: input Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: install them Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: instantiate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: institution Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: institutional Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: institutions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: instructions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: interface Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: interval Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: into Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: is contingent Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: is Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: its Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: javascript Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: jira Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: jsonschema Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: justification Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: landing Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: less Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: loading Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: log in Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: log Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: macos Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: maintenance Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: malformed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: management Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: manipulated Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: manipulation Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: marked Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: mechanism Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: message Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: metadata Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: method Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: methods Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: millisecond Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: milliseconds Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: moderator Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: moving Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: multiple Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: nonexistent Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: normalize Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: not Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: notifications Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: notify Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: oauth Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: objects Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: occurred Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: optional Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: original Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: other analytic Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: others Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: otherwise Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: our Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: overridden Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: paragraphs Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: parameter Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: params Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: particular Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: permanently Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: persistent Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: pertaining Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: please Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: positioning Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: preceded Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: predictions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: preexisting Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: preparing Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: prepopulate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: preprint Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: private Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: probabilistic Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: programmatically Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: progress Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: propagates Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: provider Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: receive Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: received Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: recommended Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: recommender Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: redirect Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: referrer Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: register Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: registration Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: registrations Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: registrationschema Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: remaining Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: remembered Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: remnants Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: replace Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: represent Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: request Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: requires Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: resolve Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: resources Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: response Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: responses Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: responsible Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: results Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: retain Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: retrieve Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: retrieves Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: returned Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: reversion Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: rolled_back Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: rules Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: sanitization Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: sanitize Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: save Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: scenario Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: schema Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: screen Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: sendgrid Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: separate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: serialized Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: set up Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: setting Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: should Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: should_be Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: situations Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: something Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: sorted Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: specific Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: study Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: subclasses Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: submissions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: submitted Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: successful Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: successfully Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: super bowl Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: supporting Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: technically Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: technique Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: template Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: test Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: than Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: that a Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: that the Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: that Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: the p-values Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: the sample Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: the Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: there are Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: there Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: threshold Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: through table Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: timed out Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: transactional Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: transition Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: trench coat Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: triangles Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unflag Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unique Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: uniqueness Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unit tests Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: universally Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unmoderated Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unnecessary Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unstructured Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unverified Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: updated Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: user Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: username Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: users Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: verifications Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: version Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: versions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: view Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: waffle Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: waterbutler Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: website Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: weight Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: when Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: whether or not Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: whether Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: which Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: with Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: withdrawn Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: won't Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: your profile be visible Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --------- Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
I can rebase to
masterif requested.Purpose
This PR corrects misspellings identified by the check-spelling action
The misspellings have been reported at https://github.com/jsoref/osf.io/actions/runs/18599108247/attempts/1#summary-53032928103
The action reports that the changes in this PR would make it mostly happy: https://github.com/jsoref/osf.io/actions/runs/18599109509/attempts/1#summary-53032931263
Changes
Spelling fixes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Certainly (there are approximately 330 sets of changes)
Ticket