attempt to fix issue #2611 #2612
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupingsse
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
dosubot
bot
added
size:XS
Author
lupingsse
force-pushed
the
resume-thread-before-chat
branch
from
5f3e5b1 to
366668d
Compare
|
This PR is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2611 for a detailled explanation of cause for this request.
Calling
contex.emitter.resume_thread(thread)after executing the hook toon_chat_resume, restores the saved thread and, thereby, overwrites any potential UI (e.g.,chainlit.Message().send()) triggered duringon_chat_resume.If we didn't overlook any specific reasons against calling
resume_theadbeforeon_chat_resume, this would fix issue #2611.