[pull] staging from MicrosoftDocs:staging #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `about_Environment_Variables` topic included misleading examples that would error if run in sequence. Additionally, the organization and content of the document hid some useful information in later sections, was difficult to follow, and lacked output examples. This commit is a rewrite and restructuring of the document. The documents new flow explains, in order: 1. The most important information about environment variables in the long description 2. How to use/change environment variables 3. How to persist changes to environment variables 4. What environment variables PowerShell adds and uses
…release notes (#8711) * - Update monthly stats and What's New - Added end-of-file markers to release notes * Apply suggestions from code review Co-authored-by: Michael T Lombardi (He/Him) <michael.t.lombardi@gmail.com> Co-authored-by: Michael T Lombardi (He/Him) <michael.t.lombardi@gmail.com>
This commit adds a new GitHub Action workflow to validate that the author of a PR can target the `live` branch. It runs whenever a PR targeting the `live` branch is opened, reopened, or synchronized (new commits are pushed or the branch is forcibly updated). It checks the collaborators of the repository for the PR author to see if they have permissions as a maintainer or administrator; no other users are authorized to target changes at the `live` branch. If the author does not have the correct permissions, the check fails. With the branch protections for the repository set to require this check when targeting `live`, this will prevent unauthorized collaborators from accidentally trying to merge their changes to the live site instead of the working branch.
…roperties (#8715) * Explain the effect of runspaces on script methods and properties * Apply suggestions from code review Co-authored-by: Michael T Lombardi (He/Him) <michael.t.lombardi@gmail.com> * Feedback edits Co-authored-by: Michael T Lombardi (He/Him) <michael.t.lombardi@gmail.com>
This commit adds an echo to the GHA for validating that a PR author has authorization to submit a PR to the Live branch. It reports the username and discovered permissions before echoing that the author has permissions or throwing if they do not.
…-live-branch-workflow (MAINT) Add echo to live branch check
Co-authored-by: Mike F. Robbins <mikefrobbins@users.noreply.github.com>
This commit reimplements the GitHub Action workflow for verifying that a pull request to the live branch has been submitted by a user who is authorized to do so. It replaces the default GitHub Action token with a repository secret, `VALID_BRANCH_TOKEN`, which is a PAT with the minimum permissions needed to retrieve the permissions of repository collaborators: - `repo:public_repo` - `read:org` It refactors the logic of the check itself to: 1. Replace the graphql query with a simpler endpoint query, passing the owner of the repository, the repository name, and the login of the pull request author to retrieve that user's permissions for the repo. 2. Adds an error handling check, throwing an error (and all output from the api call) if the query's exit code is non-zero. 3. Adds a null response check, throwing an error if the query does not return the permissions needed for further verification. 4. Converts the previous array membership check into simpler check on the new data form returned by the API. 5. Echoes the pull request author's current permissions for the repo into the run log to aid with debugging.
* Formatting fix in Wait-Job.md in 7.1 * Formatting fix in Wait-Job.md 7.0 * Formatting fix in Wait-Job.md 5.1 * Formatting fix in Wait-Job.md 7.2 * Formatting fix in Wait-Job.md 7.3
* (GH-8601) Clarify Include parameter for Copy-Item Prior to this commit, the documentation for the Include parameter of the Copy-Item cmdlet was unclear. This commit clarifies its functionality and adds a new example to show how it is used and where its behavior might be otherwise surprising. * Apply suggestions from code review * Added recurse example Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>
* Fix filename * Fix filename
* Update PowerShellGet install documents * minor edits * Apply suggestions from code review Co-authored-by: Michael T Lombardi (He/Him) <michael.t.lombardi@gmail.com> * Remove unused hostname Co-authored-by: Michael T Lombardi (He/Him) <michael.t.lombardi@gmail.com>
Prior to this commit, the documentation for PSConsoleHostReadLine did not correctly translate due to the casing of the H2s, which are required to be fully upcased. This commit upcases those items to ensure the documentation can be properly translated.
Prior to this commit, the section in **about_Format.ps1xml** incorrectly explained the `<WideEntry>` tag and did not mention the `<WideItem>` tag at all. This commit updates the section for clarity and documents the `<WideItem>` tag and its valid child tags.
Prior to this commit, the Managing Services sample in the conceptual documentation included example code using the **ComputerName** parameter for `Get-Service`, but that parameter was removed from the `*-Service` cmdlets in PowerShell 6.0. This commit updates the documentation to distinguish between Windows PowerShell and PowerShell for managing remote services and clarifies how to do so.
Prior to this commit, the EOL date for 7.1 incorrectly specified May 31, 2022. Support for PowerShell versions is tied to the version of .NET they are built on. Support for .NET 5.0, which PowerShell 7.1 is built on, ends on May 8, 2022. Additionally, the EOL date for .NET 6.0, which PowerShell 7.2 is built on, is now known to be November 8, 2024, instead of merely projected to be November 2024. This commit corrects the date for the EOL of PowerShell 7.1 and updates the EOL date of PowerShell 7.2 to ensure clarity and accuracy of the support lifecycle.
* (GH-8777) Reword here-string section for clarity This commit rewords the section of About Quoting Rules for clarity by being more explicit about the opening and closing tags and their effect. * Apply suggestions from review Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com> * (GH-8777) Rework info for clarity This commit reworks the list of distinguishing factors of a here-string into an unordered list to improve readability and clarify the info. * (GH-8777) Push changes to all versions Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )