Verify post-order traversal in test_pairs_in_post_order#685
Draft
Verify post-order traversal in test_pairs_in_post_order#685
Conversation
Copilot
AI
changed the title
[WIP] Update interning API to address review feedback
Verify post-order traversal in test_pairs_in_post_order
Jan 26, 2026
aabf999 to
fd8698b
Compare
3251a4e to
3a520de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_pairs_in_post_ordertest verified the count of pairs but not their actual ordering in post-order traversal (children before parents).Changes
(B . C)appears at index 0(A . (B . C))appears at index 1This ensures the documented post-order behavior of
InternedTree::pairsis properly tested.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.