Clarify tree hash comparison is already implemented in intern fuzzer#692
Closed
Copilot wants to merge 1 commit intogenerator-identity-hffrom
Closed
Clarify tree hash comparison is already implemented in intern fuzzer#692Copilot wants to merge 1 commit intogenerator-identity-hffrom
Copilot wants to merge 1 commit intogenerator-identity-hffrom
Conversation
Copilot
AI
changed the title
[WIP] WIP Address feedback on interning API implementation
Clarify tree hash comparison is already implemented in intern fuzzer
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review comment on #684 claimed the tree hash comparison wasn't being tested in the intern fuzzer. This was incorrect - the test already computes and compares tree hashes.
Changes
original_cache.get_or_calculate()assert_eq!(original_tree_hash, interned_tree_hash, ...)The fuzzer properly validates that
intern()preserves tree hashes as documented in the comment on line 14.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.