Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands existing Criterion benchmark coverage by adding a new, additional generator input (5.generator) to the intern and serialize benchmark suites.
Changes:
- Add
5.generatoras an embedded benchmark input inbenches/serialize.rs - Add
5.generatoras an embedded benchmark input inbenches/intern.rs
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
benches/serialize.rs |
Includes 5.generator and adds it to the serialize benchmark input set. |
benches/intern.rs |
Includes 5.generator and adds it to the intern benchmark input set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 22333171523Details
💛 - Coveralls |
arvidn
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request expands the benchmark coverage in the project by adding a new data block (
5.generator) to both the intern and serialize benchmarks.This generator was created using https://github.com/richardkiss/chia-scan and is extremely large (and probably actually exceeds the cost if we were to run it).
Note
Low Risk
Bench-only change that adds another benchmark input; main risk is longer/more resource-intensive benchmark runs due to a very large generator file.
Overview
Extends benchmark coverage by adding a new
5.generatorinput and including it in the iteration sets for bothinternandserializeCriterion benchmark groups.This increases the range of generator sizes exercised by the benchmarks without changing the benchmark logic itself.
Written by Cursor Bugbot for commit 3117d43. This will update automatically on new commits. Configure here.