Closed
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Contributor
Author
|
@SocketSecurity ignore-all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Note
High Risk
Changes core numeric operator implementations (
div,divmod,mod,modpow) by routing throughmalachite-bigint, which could affect deterministic arithmetic semantics and performance in a consensus-sensitive VM.Overview
Switches several arithmetic ops in
more_ops.rs(/,divmod,mod,modpow) to compute viamalachite-bigintby converting to/from signed big-endian byte encodings, while keeping the publicNumbertype asnum-bigint.Adds
non_empty_be_bytes()and uses it inop_pubkey_for_expto ensure a non-empty integer byte representation (e.g., zero becomes[0]) before callingG1Element::from_integer.Updates dependencies (
Cargo.toml/Cargo.lock) to includemalachite-bigintand its transitive crates, and makes a couple of small test/assertion tweaks for empty buffers.Written by Cursor Bugbot for commit a4bbb74. This will update automatically on new commits. Configure here.