Closed
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Contributor
Author
|
@SocketSecurity ignore-all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.malachite.rs/performance/
Note
High Risk
Switches core arithmetic paths (
div,divmod,mod,modpow) to a new bigint implementation, which is potentially consensus-critical and could change edge-case behavior or performance characteristics. Adds several new transitive dependencies viamalachite-bigint, increasing supply-chain and build-risk.Overview
Introduces
malachite-bigintas an additional bigint backend and wires it into the allocator and integer parsing utilities.Updates the allocator with
new_malachite_number()/malachite_number()plus shared helpers to canonicalize bigint-to-atom encoding, and switchesdiv,divmod,mod, andmodpowinmore_ops.rsto operate on Malachite integers (including updated zero/negative checks).Refreshes
Cargo.lockwith the new Malachite dependency graph and makes minor test expectation tweaks for empty buffers.Written by Cursor Bugbot for commit 2c6f31b. This will update automatically on new commits. Configure here.