Skip to content

[CHIA-3931] Malachite2wjb#715

Closed
wjblanke wants to merge 9 commits intomainfrom
malachite2wjb
Closed

[CHIA-3931] Malachite2wjb#715
wjblanke wants to merge 9 commits intomainfrom
malachite2wjb

Conversation

@wjblanke
Copy link
Contributor

@wjblanke wjblanke commented Feb 26, 2026

https://www.malachite.rs/performance/


Note

High Risk
Switches core arithmetic paths (div, divmod, mod, modpow) to a new bigint implementation, which is potentially consensus-critical and could change edge-case behavior or performance characteristics. Adds several new transitive dependencies via malachite-bigint, increasing supply-chain and build-risk.

Overview
Introduces malachite-bigint as an additional bigint backend and wires it into the allocator and integer parsing utilities.

Updates the allocator with new_malachite_number() / malachite_number() plus shared helpers to canonicalize bigint-to-atom encoding, and switches div, divmod, mod, and modpow in more_ops.rs to operate on Malachite integers (including updated zero/negative checks).

Refreshes Cargo.lock with the new Malachite dependency graph and makes minor test expectation tweaks for empty buffers.

Written by Cursor Bugbot for commit 2c6f31b. This will update automatically on new commits. Configure here.

@socket-security
Copy link

socket-security bot commented Feb 26, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedcargo/​malachite-bigint@​0.9.11001009310070

View full report

@socket-security
Copy link

socket-security bot commented Feb 26, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • cargo/bytemuck@1.25.0
  • cargo/foldhash@0.2.0
  • cargo/libm@0.2.16
  • cargo/malachite-base@0.9.1
  • cargo/malachite-bigint@0.9.1
  • cargo/malachite-nz@0.9.1
  • cargo/paste@1.0.15
  • cargo/safe_arch@1.0.0
  • cargo/wide@1.1.1
  • cargo/hashbrown@0.16.1
  • cargo/itertools@0.14.0
  • cargo/ryu@1.0.23

View full report

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@wjblanke
Copy link
Contributor Author

@SocketSecurity ignore-all

@danieljperry danieljperry changed the title Malachite2wjb [CHIA-3931] Malachite2wjb Mar 2, 2026
@wjblanke wjblanke closed this Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants