[CHIA-3932] test arithmetic operators against num-bigint results#716
[CHIA-3932] test arithmetic operators against num-bigint results#716
Conversation
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
a13d620 to
08bf011
Compare
|
@SocketSecurity ignore-all |
|
it's not obvious why All of these new dependencies come from |
aac656d to
890124f
Compare
Pull Request Test Coverage Report for Build 22552638384Details
💛 - Coveralls |
|
The original version of this PR used |
This adds fuzzers for the arithmetic CLVM operators, to ensure they agree with the result from num-bigint, including failures.
Note
Medium Risk
Moderate risk: adds new fuzz targets and dependency updates in the fuzzing crate plus relaxes Coveralls failures in CI; no production runtime logic changes, but CI/coverage behavior and fuzz coverage change.
Overview
Adds new fuzz targets (
arithmetic,divmod,modpow) that compare CLVM arithmetic operator results (and expected failure cases like invalid shifts/div-by-zero/invalid modpow inputs) againstnum-bigint/num-integerreference behavior.Introduces a shared
clvm-fuzzing::build_argshelper to construct argument lists for these fuzzers, updates the fuzz crate dependencies/lockfile accordingly, and makes the Coveralls upload step in the coverage workflow non-fatal (continue-on-error/fail-on-error: false).Written by Cursor Bugbot for commit e5c2d54. This will update automatically on new commits. Configure here.