Skip to content

[CHIA-3933] enable asm feature for sha3 dependency#717

Merged
arvidn merged 1 commit intomainfrom
faster-keccak
Mar 1, 2026
Merged

[CHIA-3933] enable asm feature for sha3 dependency#717
arvidn merged 1 commit intomainfrom
faster-keccak

Conversation

@arvidn
Copy link
Contributor

@arvidn arvidn commented Mar 1, 2026

This makes the keccak256 operator faster.


Note

Low Risk
Low risk dependency/config change; main risk is build portability if some targets/toolchains don’t support the sha3 asm feature.

Overview
Enables the sha3 crate’s asm feature to use optimized assembly implementations for the keccak256 operator.

Updates Cargo.lock accordingly (including bumping the keccak transitive dependency to 0.1.6).

Written by Cursor Bugbot for commit d31d083. This will update automatically on new commits. Configure here.

@arvidn arvidn requested a review from Rigidity March 1, 2026 14:22
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@coveralls-official
Copy link

coveralls-official bot commented Mar 1, 2026

Pull Request Test Coverage Report for Build 22546629127

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.222%

Totals Coverage Status
Change from base Build 22327026712: 0.0%
Covered Lines: 6831
Relevant Lines: 7743

💛 - Coveralls

Rigidity
Rigidity previously approved these changes Mar 1, 2026
@arvidn arvidn merged commit 176fa1a into main Mar 1, 2026
32 checks passed
@arvidn arvidn deleted the faster-keccak branch March 1, 2026 16:18
@danieljperry danieljperry changed the title enable asm feature for sha3 dependency [CHIA-3933] enable asm feature for sha3 dependency Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants