[CHIA-3933] enable asm feature for sha3 dependency#717
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Pull Request Test Coverage Report for Build 22546629127Details
💛 - Coveralls |
Rigidity
previously approved these changes
Mar 1, 2026
Rigidity
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
keccak256operator faster.Note
Low Risk
Low risk dependency/config change; main risk is build portability if some targets/toolchains don’t support the
sha3asmfeature.Overview
Enables the
sha3crate’sasmfeature to use optimized assembly implementations for thekeccak256operator.Updates
Cargo.lockaccordingly (including bumping thekeccaktransitive dependency to0.1.6).Written by Cursor Bugbot for commit d31d083. This will update automatically on new commits. Configure here.