Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Contributor
Author
|
@SocketSecurity ignore cargo/minicov@0.3.8 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Pull Request Test Coverage Report for Build 22691930026Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rayon doesn't support wasm32, which is used by criterion. So benchmarks are disabled for wasm32.
Note
Medium Risk
Mostly build/test and target-specific dependency changes, but it also changes atom-size acceptance and parsing behavior in
serde/parse_atom.rs, which could affect compatibility for extremely large serialized inputs.Overview
Adds
wasm32-unknown-unknownsupport across the crate and CI.CI now runs a dedicated
wasm_testsjob that installswasm-bindgen-test-runnerand executescargo testfor theclvmrcrate on the WASM target;rust-toolchain.tomlalso includes the WASM target.To make tests portable, a
wasm_compat::testshim is introduced and applied broadly so unit/rstesttests can run underwasm-bindgen-test; WASM builds also avoidcriterion(Rayon) by making it a non-wasm dev-dependency, add WASM-specificgetrandomconfiguration, and embed op-test fixtures viainclude_str!for WASM. Serialization parsing is tightened for WASM by bounding atom sizes to fit inusize(32-bit) and using fallibleusizeconversions when slicing/advancing cursors.Written by Cursor Bugbot for commit 94c2221. This will update automatically on new commits. Configure here.