Bump dependencies, add commonmark caching, eliminate nested event loops.#7
Open
willbicks wants to merge 3 commits intoChrisRega:mainfrom
Open
Bump dependencies, add commonmark caching, eliminate nested event loops.#7willbicks wants to merge 3 commits intoChrisRega:mainfrom
willbicks wants to merge 3 commits intoChrisRega:mainfrom
Conversation
…test Update to time crate fixes compilation on Rust >= 1.80.0.
Improves scrolling of posts, especially with code blocks.
Eliminates nested event loops, fixes ChrisRega#6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this neat demo, it was useful as I'm evaluating approaches to building egui apps! I ended up making a few tweaks as I was getting it running, and wanted to contribute them back for others who may also be evaluating this approach.
First, this PR updates
eguiand related dependencies to latest versions to represent current APIs, and updatestimeto fix compilation on rust >= 1.80.0.It also adds an app-wide
egui_commonmarkcache instead of replacing the cache on redraws, which greatly improves scrolling performance of posts, especially with multiple code blocks (below video shows the 'before' on the left, 'after' on the right).2025-01-23.17-20-33.mp4
Finally, I took a stab at fixing #6, based on the approach used in https://github.com/parasyte/egui-tokio-example. I am definetly new to Tokio so I'm not 100% confident on this approach, but I am more than open to comments!