Open
Conversation
Created with Claude AI.
This removes the need to install NodeJS + meshcore-decoder.
Owner
|
It would be nice to split the python signing implementation into its own change. I dont really like the idea of storing the keys in config and would rather see it available in the protocol. Ideally the node does the signing and the private key never leaves the node (like companions do) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for connecting to BLE devices for mesh packet logging.
Corresponding MeshCore PR: meshcore-dev/MeshCore#2039, which adds BLE mesh packet logging support to MeshCore.
This approach has a few notable aspects:
I've tested this with my branch of MeshCore on a Heltec Wireless Tracker, and this PR on a macbook.
Limitation: this PR doesn't deal with statistics, as those are requested by meshcoretomqtt via the serial connection. In order to implement that over BLE, that needs to be designed first. For one, that would need some reconsideration whether it's desirable to expose via unauthenticated BLE calls.
Disclaimer: this PR was made with the help of Claude AI. I'm a human, though, and happy to personally work on any feedback.