Prevent packets from having dangerously sized collections (Electric Boogaloo)#125
Merged
Protonull merged 12 commits intoCivPlatform:mainfrom Mar 26, 2026
Merged
Conversation
Protonull
force-pushed
the
fix-oversized-packet-crash
branch
2 times, most recently
from
7c1505d to
37be1cf
Compare
Copied near-verbatim from #110
These had a weird mixture of interface and namespace. They've now just been replaced with classes and each consolidated into one file.
Turns out that doing an aggregate function like MAX without having a group by, in this case, is a *bad* idea. Also I seemed to have forgotten that regions are 32x32, not 16x16 :s
This also involved switching over to a typed-ish bigint system, which means switching over the database to use them, etc.
This is one of the drawbacks of Java's refusal to support unsigned integers: casting a value from one integer type to another actually changes its binary structure.
Protonull
force-pushed
the
fix-oversized-packet-crash
branch
from
37be1cf to
f8ba925
Compare
Collaborator
Author
|
This took a little longer than expected as I began fretting about ensuring that any u5 value is actually a valid u5, etc, but I believe it's about ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will implement #121