Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 23, 2025

Why

PR #856 changed local-runner to create a temporary venv by default, breaking the original behavior where it ran in the current user environment. This restores that behavior as the default while preserving the new modes.

How

  • Added 'current' mode to run in user's existing environment (no venv creation)
  • Changed default from 'env' to 'current'
  • Updated CLI option to --mode [current|env|container] with explicit elif branches for each mode
  • Added test_local_runner_mode_options to verify all three modes

Tests

  • All 8 existing tests pass with new default
  • New test validates:
    • Default mode skips venv creation
    • --mode env creates venv and installs requirements
    • --mode current explicitly skips venv creation

Notes

  • Only affects local-runner command; local-test and local-grpc unchanged per issue scope
Original prompt

This section details on the original issue you should resolve

<issue_title>Change local-runner default mode to current user env</issue_title>
<issue_description>Change the local-runner default env model to current user env, instead of creating a new venv.
Refer the code -

@click.option(

During this PR , we have added 2 new modes like env and container with local-runner, prior to that it will be only running in the user env, where the cli command is triggered.

Now please make sure it has the previous functionality along with this 2 new modes to run.</issue_description>

<agent_instructions>Change the local-runner default env model to current user env, instead of creating a new venv.
Refer the code -

@click.option(

During this PR , we have added 2 new modes like env and container with local-runner, prior to that it will be only running in the user env, where the cli command is triggered.

Now please make sure it has the previous functionality along with this 2 new modes to run.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 4 commits December 23, 2025 11:26
Co-authored-by: mogith-pn <143642606+mogith-pn@users.noreply.github.com>
Co-authored-by: mogith-pn <143642606+mogith-pn@users.noreply.github.com>
Co-authored-by: mogith-pn <143642606+mogith-pn@users.noreply.github.com>
Co-authored-by: mogith-pn <143642606+mogith-pn@users.noreply.github.com>
Copilot AI changed the title [WIP] Change local-runner default mode to current user env Change local-runner default mode to current user environment Dec 23, 2025
Copilot AI requested a review from mogith-pn December 23, 2025 11:36
@github-actions
Copy link

Code Coverage

Package Line Rate Health
clarifai 45%
clarifai.cli 62%
clarifai.cli.templates 46%
clarifai.client 68%
clarifai.client.auth 67%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 0%
clarifai.runners 54%
clarifai.runners.models 61%
clarifai.runners.pipeline_steps 41%
clarifai.runners.pipelines 77%
clarifai.runners.utils 62%
clarifai.runners.utils.data_types 72%
clarifai.schema 100%
clarifai.urls 60%
clarifai.utils 60%
clarifai.utils.evaluation 67%
clarifai.workflows 95%
Summary 63% (9200 / 14628)

Minimum allowed line rate is 50%

@mogith-pn mogith-pn marked this pull request as ready for review December 23, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Change local-runner default mode to current user env

2 participants