Replacing and by logical_and in the supported operators for arithmetics #1286
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
matanvax2
reviewed
Nov 6, 2025
Member
matanvax2
left a comment
matanvax2
left a comment
There was a problem hiding this comment.
This notebook is obsolete, misleading, and IMO misplaced. Start with the utterly wrong opening sentence -
Use the
Arithmeticfunction to write complex mathematical expression in free format.
IMO this whole directory should be removed and users should be refered to the manual for explanations and examples..
Happy for @TomerGoldfriend and @orsa-classiq to chime in here.
| "- Less Or Equal: `<=`\n", | ||
| "- Modulo: `%` limited for power of 2\n", | ||
| "- Logical And: `and`\n", | ||
| "- Logical And: `logical_and`\n", |
Member
There was a problem hiding this comment.
What about the 'or'? What about 'not'. Probably need to mention that other operators are imported from 'classiq.qmod.symbolic' as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Pythonic
andis being indicated as a supported operator for arithmetics while the correct operator islogical_and. This PR replacesandto the correct version.