Skip to content

Conversation

@dhtclk
Copy link
Collaborator

@dhtclk dhtclk commented Oct 28, 2025

Summary

Creating a componented for tracking CTA links with galaxy, and adding a CTA for clickstack private preview.

Checklist

@vercel
Copy link

vercel bot commented Oct 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clickhouse-docs Error Error Comment Oct 28, 2025 9:39pm
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
clickhouse-docs-jp Ignored Ignored Oct 28, 2025 9:39pm
clickhouse-docs-ru Ignored Ignored Oct 28, 2025 9:39pm
clickhouse-docs-zh Ignored Ignored Oct 28, 2025 9:39pm

@dhtclk dhtclk marked this pull request as ready for review October 28, 2025 21:30
@dhtclk dhtclk requested a review from a team as a code owner October 28, 2025 21:30
Copy link
Member

@Blargian Blargian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with exception of the eventName strings which need to change to match the Galaxy convention.

<TrackedLink href="https://clickhouse.com/cloud/clickstack-private-preview" eventName="clickstack.deployment.waitlist.cta">join the waitlist</TrackedLink>.

If you're new to ClickHouse Cloud click
<TrackedLink href="/docs/cloud/overview" eventName="clickstack.deployment.cloud_learn_more.cta">here</TrackedLink> to learn more or <TrackedLink href="https://clickhouse.cloud/signUp" eventName="clickstack.deployment.cloud_signup.cta" target="_blank" rel="noopener noreferrer">sign up for a free trial</TrackedLink> to get started.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<TrackedLink href="/docs/cloud/overview" eventName="clickstack.deployment.cloud_learn_more.cta">here</TrackedLink> to learn more or <TrackedLink href="https://clickhouse.cloud/signUp" eventName="clickstack.deployment.cloud_signup.cta" target="_blank" rel="noopener noreferrer">sign up for a free trial</TrackedLink> to get started.
<TrackedLink href="/docs/cloud/overview" eventName="clickstack.deployment.cloud_learn_more.cta">here</TrackedLink> to learn more or <TrackedLink href="https://clickhouse.cloud/signUp" eventName="docs.clickstack_deployment.cloud_signup_cta" target="_blank" rel="noopener noreferrer">sign up for a free trial</TrackedLink> to get started.

You need to use only three qualifiers. These map to fields in Galaxy for namespace.component.eventName so eventName above should not have more than 3 dots in it... "clickstack" will correspond to field namespace, "deployment" to component and "cloud_signup" to event in the DWH table where galaxy data lands, so ".cta" has no meaning in this case, i'm not sure how galaxy would handle that - if it would discard it or include it in the event column... not sure.

To keep things consistent with how we have them already I suggest: docs.clickstack_deployment.cloud_signup_cta

namespace = "docs"
component="clickstack_deployment"
event="cloud_signup_cta"

{children}
</a>
);
}; No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline end of file

Comment on lines +29 to +30
If you're new to ClickHouse Cloud click
<TrackedLink href="/docs/cloud/overview" eventName="clickstack.deployment.cloud_learn_more.cta">here</TrackedLink> to learn more or <TrackedLink href="https://clickhouse.cloud/signUp" eventName="clickstack.deployment.cloud_signup.cta" target="_blank" rel="noopener noreferrer">sign up for a free trial</TrackedLink> to get started.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you're new to ClickHouse Cloud click
<TrackedLink href="/docs/cloud/overview" eventName="clickstack.deployment.cloud_learn_more.cta">here</TrackedLink> to learn more or <TrackedLink href="https://clickhouse.cloud/signUp" eventName="clickstack.deployment.cloud_signup.cta" target="_blank" rel="noopener noreferrer">sign up for a free trial</TrackedLink> to get started.
If you're new to ClickHouse Cloud, click
<TrackedLink href="/docs/cloud/overview" eventName="clickstack.deployment.cloud_learn_more.cta">here</TrackedLink> to learn more or <TrackedLink href="https://clickhouse.cloud/signUp" eventName="clickstack.deployment.cloud_signup.cta" target="_blank" rel="noopener noreferrer">sign up for a free trial</TrackedLink> to get started.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue with the eventName here, it should have 3 parts corresponding to namespace, component and event that Galaxy expects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants