-
Couldn't load subscription status.
- Fork 395
Tracked link component and clickstack CTA #4662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with exception of the eventName strings which need to change to match the Galaxy convention.
| <TrackedLink href="https://clickhouse.com/cloud/clickstack-private-preview" eventName="clickstack.deployment.waitlist.cta">join the waitlist</TrackedLink>. | ||
|
|
||
| If you're new to ClickHouse Cloud click | ||
| <TrackedLink href="/docs/cloud/overview" eventName="clickstack.deployment.cloud_learn_more.cta">here</TrackedLink> to learn more or <TrackedLink href="https://clickhouse.cloud/signUp" eventName="clickstack.deployment.cloud_signup.cta" target="_blank" rel="noopener noreferrer">sign up for a free trial</TrackedLink> to get started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <TrackedLink href="/docs/cloud/overview" eventName="clickstack.deployment.cloud_learn_more.cta">here</TrackedLink> to learn more or <TrackedLink href="https://clickhouse.cloud/signUp" eventName="clickstack.deployment.cloud_signup.cta" target="_blank" rel="noopener noreferrer">sign up for a free trial</TrackedLink> to get started. | |
| <TrackedLink href="/docs/cloud/overview" eventName="clickstack.deployment.cloud_learn_more.cta">here</TrackedLink> to learn more or <TrackedLink href="https://clickhouse.cloud/signUp" eventName="docs.clickstack_deployment.cloud_signup_cta" target="_blank" rel="noopener noreferrer">sign up for a free trial</TrackedLink> to get started. |
You need to use only three qualifiers. These map to fields in Galaxy for namespace.component.eventName so eventName above should not have more than 3 dots in it... "clickstack" will correspond to field namespace, "deployment" to component and "cloud_signup" to event in the DWH table where galaxy data lands, so ".cta" has no meaning in this case, i'm not sure how galaxy would handle that - if it would discard it or include it in the event column... not sure.
To keep things consistent with how we have them already I suggest: docs.clickstack_deployment.cloud_signup_cta
namespace = "docs"
component="clickstack_deployment"
event="cloud_signup_cta"
| {children} | ||
| </a> | ||
| ); | ||
| }; No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline end of file
| If you're new to ClickHouse Cloud click | ||
| <TrackedLink href="/docs/cloud/overview" eventName="clickstack.deployment.cloud_learn_more.cta">here</TrackedLink> to learn more or <TrackedLink href="https://clickhouse.cloud/signUp" eventName="clickstack.deployment.cloud_signup.cta" target="_blank" rel="noopener noreferrer">sign up for a free trial</TrackedLink> to get started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| If you're new to ClickHouse Cloud click | |
| <TrackedLink href="/docs/cloud/overview" eventName="clickstack.deployment.cloud_learn_more.cta">here</TrackedLink> to learn more or <TrackedLink href="https://clickhouse.cloud/signUp" eventName="clickstack.deployment.cloud_signup.cta" target="_blank" rel="noopener noreferrer">sign up for a free trial</TrackedLink> to get started. | |
| If you're new to ClickHouse Cloud, click | |
| <TrackedLink href="/docs/cloud/overview" eventName="clickstack.deployment.cloud_learn_more.cta">here</TrackedLink> to learn more or <TrackedLink href="https://clickhouse.cloud/signUp" eventName="clickstack.deployment.cloud_signup.cta" target="_blank" rel="noopener noreferrer">sign up for a free trial</TrackedLink> to get started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue with the eventName here, it should have 3 parts corresponding to namespace, component and event that Galaxy expects
Summary
Creating a componented for tracking CTA links with galaxy, and adding a CTA for clickstack private preview.
Checklist