Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a configurable SNI/certificate-validation hostname override for ClickHouse TLS connections (via CLICKHOUSE_SERVER_HOST_NAME) to support connecting through load balancers/proxies where the connection endpoint hostname differs from the certificate hostname.
Changes:
- Introduces
CLICKHOUSE_SERVER_HOST_NAMEto override TLS SNI / hostname validation by passingserver_host_nameintoclickhouse_connect.get_client. - Updates connection logging to include
server_host_namewhen configured. - Documents the new environment variable in the README.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
mcp_clickhouse/mcp_server.py |
Logs server_host_name when present to make TLS/SNI overrides visible in runtime diagnostics. |
mcp_clickhouse/mcp_env.py |
Adds CLICKHOUSE_SERVER_HOST_NAME env var support and includes it in the ClickHouse client config dict. |
README.md |
Documents CLICKHOUSE_SERVER_HOST_NAME usage and behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…y-paths-for-clickhouse-connections
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
CLICKHOUSE_SERVER_HOST_NAMEenvironment variable to enable SNI (Server Name Indication) override during TLS connections.Usage
Closes #126