[chore]: bump mcp to >=1.26.0 to mitigate DNS rebinding and align with FastMCP 3.x#150
Open
shuvajyotikar13 wants to merge 2 commits intoClickHouse:mainfrom
Open
[chore]: bump mcp to >=1.26.0 to mitigate DNS rebinding and align with FastMCP 3.x#150shuvajyotikar13 wants to merge 2 commits intoClickHouse:mainfrom
shuvajyotikar13 wants to merge 2 commits intoClickHouse:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the core dependency bounds in pyproject.toml to address a critical security vulnerability and ensure compatibility with the latest FastMCP framework architectural changes.
Key Changes
Context: Versions of the Python MCP SDK prior to 1.23.0 are vulnerable to a DNS rebinding attack. In a database context like ClickHouse, this is particularly risky as it could allow a malicious webpage to execute unauthorized SQL queries against a local ClickHouse instance via the MCP server's network interface.
Reasoning: The ClickHouse server implementation leverages FastMCP for resource and tool exposure. FastMCP 3.x introduces significant protocol lifecycle improvements that require the 1.26.x baseline of the underlying SDK for optimal stability.
Validation
Synchronized local environment using uv sync.
Verified that the ClickHouse connection and schema-listing tools remain functional under the updated protocol version.
passed ruff check and internal linting.