fix: improve pylint score for web.models module #4793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix __str__ method in UserStatus modell to return str(self.name) instead of self.name - Rename conflicting admin classes to avoid redefinition errors: - UserAdmin -> CustomUserAdmin - TokenAdmin -> CustomTokenAdmin - EmailAddressAdmin -> CustomEmailAddressAdmin - Replace old-style string formatting with f-strings in views.py - Fix typo: recieve_newsletter -> receive_newsletter - Improve search fields in ProfileAdmin Pylint score improved from ~8.17 to 9.58/10 for accounts module. Overall pylint score improved to 8.20/10 (above target of 7.5). Fixes Cloud-CV#4557
- Revert admin field name from 'receive_newsletter' to 'recieve_newsletter' - This matches the actual field name in the Profile model - Fixes Django system check errors that were causing CI to fail The field name in the model still has the typo, but changing it would require a database migration. For now, keeping the admin consistent with the model.
- Fix __str__ method in Team model to return str(self.name) instead of self.name - Replace old-style string formatting with f-strings in Contact and Subscribers models - Pylint score improved from ~9.55 to 10.00/10 for web.models module Continues work on issue Cloud-CV#4557
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4793 +/- ##
==========================================
+ Coverage 91.89% 91.90% +0.01%
==========================================
Files 86 86
Lines 7132 7132
==========================================
+ Hits 6554 6555 +1
+ Misses 578 577 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Author
|
hey @RishabhJain2018 pr is ready for review ,pls have a look |
Author
|
@RishabhJain2018 review required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the pylint score for the web.models module as part of issue #4557.
=> Changes Made
__str__method in Team model to returnstr(self.name)instead ofself.name__str__method to use f-string formatting__str__method to use f-string formatting=> Pylint Score Improvements
=> Testing
Continues work on issue #4557