Fix #4166: Allow deletion of challenge phases during update #4851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nandkishore-04
force-pushed
the
fix-issue-4166-challenge-phase-deletion
branch
4 times, most recently
from
25f0158 to
7c9c54d
Compare
- Removed validation that blocked deleting phases during challenge updates. - Updated unit tests to verify that deletion is allowed. - Fixed Pylint warnings and improved code quality.
Nandkishore-04
force-pushed
the
fix-issue-4166-challenge-phase-deletion
branch
from
97f710d to
74098ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4166.
Removed validation from challenge_config_utils.py that blocked users from deleting challenge phases during updates. Verified that existing phases can now be deleted whereas adding new phases remains restricted.