Skip to content

WIP: Various improments to rust/python srpc interop library #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

WIP: Various improments to rust/python srpc interop library #121

wants to merge 27 commits into from

Conversation

@merc1031
Copy link

@merc1031 merc1031 commented Dec 14, 2024 •
edited
Loading

  • Use a Config struct + Client Struct to remove need for Option<...Tcp> checks
  • Add tracing logs in rust
  • Plumb tracing logs into python
  • Format everything
  • Remove case @rgooch claims doesnt happen
  • Allow streaming into python (some code duplication due to pyo3 limitation with generics)
  • Allow should_continue to be passed in, and add a variant that passes it as a callback
  • Add configurable buffer sizes

Discussion pr with @ramkumar-s at https://github.com/ramkumar-s/Dominator/pull/1

Leonidas Loucas added 17 commits December 11, 2024 19:05
fix: Using 2 structs can remove some is_none Some checks
b80c7a1 
Remove unrepresentable state

Also in the pure rust case, i believe this means the original connection
is consumed, and not re-usable , so you must use the new one.

In python due to the need for a clone im not sure this holds
feat: add tracing for logs
84a51db
feat: Add tracing to example
53f9295
style: remove dead code
a08c509
style: Remove unused imports
df2ac14
style: run cargo fmt
b2dbb21
style: run black
613c798
refactor: Reduce 1 level of nesting with and_then
cd2f909
chore: add log line when processing buffer
bd78a4c
fix: @rgooch says this shouldnt happen and is handle in next case
b6df1e4
feat: Allow streaming responses to python
386166e
chore: Examples for streaming responses
7e7147a
feat: Allow passing a callback from python
7739f58
feat: switch to a more idiomatic FrameRead *LineCodec
90dd80b 
Also add ReceiveOptions for future testing
chore: Make examples use env vars for flexibility
02560b1
chore: loosen bounds and bump version for api change
7f0e6bc
chore: Abstract to try to add test seam
4d2f7da
@merc1031 merc1031 force-pushed the multiple-structs branch 2 times, most recently from 0e44efb to eae20f8 Compare December 14, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@merc1031