Glasgow | Sheetal Kharab | Module-Complexity | Sprint 2 | Improve code with precomputing#41
Conversation
sheetalkharab
added
the
Needs Review
OracPrime
added
Review in progress
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
One typo worth quickly correcting in the otherwise good Sprint 2 work. You need to remove the Sprint 1 files
| # only_upper.add(letter) | ||
| # return len(only_upper) | ||
| uppercase_letters : Set[str] = set() | ||
| lowecase_letters : Set[str] = set() |
| only_upper.add(letter) | ||
| return len(only_upper) | ||
| uppercase_letters.add(letter) | ||
| elif letter.isalpha(): |
There was a problem hiding this comment.
Nice - picking up the non-letter case
OracPrime
added
Reviewed
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
2 participants
Learners, PR Template
Self checklist
Changelist
change for common_prefix and count_letters file
Questions
no