NW6 | Fikret Ellek | Module-DataBases | [TECH ED] Big Spender | week 2#161
Open
fikretellek wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
NW6 | Fikret Ellek | Module-DataBases | [TECH ED] Big Spender | week 2#161fikretellek wants to merge 1 commit intoCodeYourFuture:mainfrom
fikretellek wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
|
sayoiscool
reviewed
Jun 15, 2024
sayoiscool
left a comment
sayoiscool
left a comment
There was a problem hiding this comment.
Excellent work overall. Well done
|
|
||
| ```sql | ||
| INSERT YOUR QUERY HERE | ||
| SELECT * FROM spends WHERE LOWER(description) LIKE '%fee%'; |
There was a problem hiding this comment.
Good work taking the capitlisations into consideration with 'LOWER'
|
|
||
| ```sql | ||
| INSERT YOUR QUERY HERE | ||
| SELECT s.*, e.expense_area FROM spends s JOIN expense_areas e ON s.expense_area_id=e.id WHERE LOWER(e.expense_area) LIKE '%better hospital food%'; |
|
|
||
| ```sql | ||
| CREATE YOUR QUERY HERE | ||
| SELECT DATE_TRUNC('month', date)::DATE AS month, SUM(amount) AS total_amount FROM spends GROUP BY month ORDER BY month; |
There was a problem hiding this comment.
Nice work with the date format in your select statement!
| INSERT INTO expense_types (expense_type) | ||
| SELECT 'Hardware' | ||
| WHERE NOT EXISTS ( | ||
| SELECT 1 FROM expense_types WHERE expense_type = 'Hardware' |
There was a problem hiding this comment.
Great attention to detail! The 'Hardware', 'Dell', and 'IT' rows were missing from the other tables, and you've done well by adding the necessary insert statements to populate them.
sayoiscool
approved these changes
Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.