NW6 | Fikret Ellek | Module-Database | E-Commerce-Api | Week 4#170
Open
fikretellek wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
NW6 | Fikret Ellek | Module-Database | E-Commerce-Api | Week 4#170fikretellek wants to merge 3 commits intoCodeYourFuture:mainfrom
fikretellek wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const { Pool } = pg; | ||
|
|
||
| const pool = new Pool({ | ||
| connectionString: "postgresql://admin:3214@localhost:5432/cyf_ecommerce", |
Check failure
Code scanning / SonarCloud
PostgreSQL database passwords should not be disclosed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
I have created my test cases for the api and implemented my api according to my database. I couldn't work much on the documentation but I'll work on in in the future.
Questions
Ask any questions you have for your reviewer.