Skip to content

Conversation

@fayaz551
Copy link

You must title your PR like this:

Region | Cohort | FirstName LastName | Sprint | Assignment Title

For example,

London | 25-ITP-May | Carol Owen | Sprint 1 | Alarm Clock

Fill in the template below - remove any sections that don't apply.

Complete the self checklist - replace each empty box in the checklist [ ] with a [x].

Add the label "Needs Review" and you will get review.

Respond to volunteer reviews until the volunteer marks it as "Complete".

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

i have added the form to collect information of customer like his name and email address and then proceeded to make tags to get the custom order from the customer.

Questions

i dont have any questions at the moment.

@netlify
Copy link

netlify bot commented Jan 20, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit d60e871
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69700b931f02ae0008e9efc9
😎 Deploy Preview https://deploy-preview-1001--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@fayaz551 fayaz551 changed the title London | ITP-2026-JAN | Said Fayaz Sadat | sprint 1 | Form-comtrols London | ITP-2026-Jan | Said Fayaz Sadat | sprint 1 | Form comtrols Jan 20, 2026
@github-actions

This comment has been minimized.

@fayaz551 fayaz551 changed the title London | ITP-2026-Jan | Said Fayaz Sadat | sprint 1 | Form comtrols London | ITP-2026-Jan | Said Fayaz Sadat | sprint 1 | Form controls Jan 20, 2026
@github-actions

This comment has been minimized.

@fayaz551 fayaz551 changed the title London | ITP-2026-Jan | Said Fayaz Sadat | sprint 1 | Form controls London | ITP-2026-Jan | Said Fayaz Sadat | sprint 2 | Form controls Jan 20, 2026
@fayaz551 fayaz551 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 20, 2026
@takanocap takanocap added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 27, 2026

<br><br>

<label for="colour">T‑shirt Colour:</label>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done for the good job.
are you able to find a way to validate the (dropdown menu) ? is there a way to use "value" for the each option of the select element? Does this affect the required attribute? see https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/select Additional research - (may not be required) see below: can you use input with pattern for validation in this case too and datalist validation? see this page may be of help https://developer.mozilla.org/en-US/docs/Learn_web_development/Extensions/Forms/Form_validation

id="name"
name="name"
required
pattern="[A-Za-z ]{2,}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use minlength instead of the pattern ?

id="email"
name="email"
required
placeholder="example@email.com">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use minlength to validate the email too ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants