-
-
Notifications
You must be signed in to change notification settings - Fork 401
London | ITP-2026-Jan | Said Fayaz Sadat | sprint 2 | Form controls #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| <br><br> | ||
|
|
||
| <label for="colour">T‑shirt Colour:</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done for the good job.
are you able to find a way to validate the (dropdown menu) ?
is there a way to use "value" for the each option of the select element? Does this affect the required attribute? see https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/select
Additional research - (may not be required) see below:
can you use input with pattern for validation in this case too and datalist validation? see this page may be of help https://developer.mozilla.org/en-US/docs/Learn_web_development/Extensions/Forms/Form_validation
| id="name" | ||
| name="name" | ||
| required | ||
| pattern="[A-Za-z ]{2,}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use minlength instead of the pattern ?
| id="email" | ||
| name="email" | ||
| required | ||
| placeholder="example@email.com"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use minlength to validate the email too ?

You must title your PR like this:
Region | Cohort | FirstName LastName | Sprint | Assignment Title
For example,
London | 25-ITP-May | Carol Owen | Sprint 1 | Alarm Clock
Fill in the template below - remove any sections that don't apply.
Complete the self checklist - replace each empty box in the checklist [ ] with a [x].
Add the label "Needs Review" and you will get review.
Respond to volunteer reviews until the volunteer marks it as "Complete".
Learners, PR Template
Self checklist
Changelist
i have added the form to collect information of customer like his name and email address and then proceeded to make tags to get the custom order from the customer.
Questions
i dont have any questions at the moment.